third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py - Issue 1888963003: Make NeedsRebaseline illegal in layout_test TestExpectations for now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py

Issue 1888963003: Make NeedsRebaseline illegal in layout_test TestExpectations for now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: disable broken webkitpy tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py

index dd8fa4a9f9cc1cfab0b14e533df852e370532831..c5e1b15b59cee90ec493cce3aad0669e55baf174 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py

@@ -101,7 +101,8 @@ class LintTest(unittest.TestCase):

self.assertEqual(res, [])

self.assertEqual(host.ports_parsed, ['a', 'b', 'b-win'])

- def test_lint_test_files(self):

+ # TODO(crbug.com/188963003) - reenable this when the ARB is restarted.

+ def disabled_test_lint_test_files(self):

logging_stream = StringIO.StringIO()

options = optparse.Values({'platform': 'test-mac-mac10.10'})

host = MockHost()