Issue 188893003: Revert 255091 "linux_aura: Fix all instances of LabelButton sizing."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 188893003: Revert 255091 "linux_aura: Fix all instances of LabelButton sizing." (Closed)

Created:
6 years, 9 months ago by Elliot Glaysher

Modified:
6 years, 9 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 255091 "linux_aura: Fix all instances of LabelButton sizing." Patch is incorrect. Changing the behaviour of insets also breaks the toolbar. Looks like I'm going to have to find all usage of LabelButton::set_min_size() after all. > linux_aura: Fix all instances of LabelButton sizing. > > Previous attempts at fixing this involved tracking down each button > which was setting the minimum size to 0,0. Those attempts are reverted, > as I no longer think they're wrong. The actual fix is to pass through > the views inset size instead of using the GTK inset size. > > BUG=349183, 344498, 339247 > R=msw@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/187133003 TBR=erg@chromium.org,msw@chromium.org,sky@chromium.org BUG=349777 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255406

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -3 lines)			Patch
M	trunk/src/chrome/browser/ui/libgtk2ui/gtk2_border.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/views/fullscreen_exit_bubble_views.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/views/controls/button/label_button.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/ui/views/window/dialog_client_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Elliot Glaysher

6 years, 9 months ago (2014-03-06 19:11:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r255406 (tree was closed).