Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 187133003: linux_aura: Fix all instances of LabelButton sizing. (Closed)

Created:
6 years, 9 months ago by Elliot Glaysher
Modified:
6 years, 9 months ago
Reviewers:
msw, sky
CC:
chromium-reviews
Visibility:
Public.

Description

linux_aura: Fix all instances of LabelButton sizing. Previous attempts at fixing this involved tracking down each button which was setting the minimum size to 0,0. Those attempts are reverted, as I no longer think they're wrong. The actual fix is to pass through the views inset size instead of using the GTK inset size. BUG=349183, 344498, 339247 R=msw@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255091

Patch Set 1 #

Patch Set 2 : Revert on the right branch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_border.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Elliot Glaysher
msw: review the gtk2_border.cc change. sky: owners stamp the rest which are reverts of my ...
6 years, 9 months ago (2014-03-04 23:23:07 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-04 23:51:21 UTC) #2
msw
lgtm
6 years, 9 months ago (2014-03-04 23:55:51 UTC) #3
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 9 months ago (2014-03-04 23:56:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/187133003/20001
6 years, 9 months ago (2014-03-05 00:02:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/187133003/20001
6 years, 9 months ago (2014-03-05 01:20:44 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 06:51:17 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275037
6 years, 9 months ago (2014-03-05 06:51:18 UTC) #8
Elliot Glaysher
6 years, 9 months ago (2014-03-05 18:32:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r255091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698