Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 18889006: Removed old media-internals page and rewrote it. (Closed)

Created:
7 years, 5 months ago by Ty Overby
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removed old media-internals page and rewrote it. Improvements over old media-internals page: * Easily accessible list of players: * Under the old page, the data of a player was built into the list of overall players. This meant that if you wanted to toggle between two players, it was practically impossible. * The new UI has a list of buttons for each player that is unobstructed by the data on the page. * Useful log view. * The old log viewer displayed all the data sent about that player regardless of if the user wanted to see it or if it should even be in the log in the first place. * The new log viewer automatically filters out log status like if is_downloading and other properties about the buffer status that change hundreds of times per second and are better viewed in the properties panel or in in a graph. * The new log view also has a filter text-box that lets you filter the log for events of a certain property. (The text box accepts comma-separated values of property names.) * Lasting information * If a media player unexpectedly quit, the old media-internals page would immediately kick it off the page. If the quit was unexpected, this might not be the best decision. * The new page has a checkbox for if you want to remove dead video players. * System Properties * Code is in place (but not yet used) that will allow for the page to display properties about the entire system instead of just a single video player. A backend change will be necessary to utilize this. BUG=260005

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved all 'new' media internals files into its own folder for a smooth transition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1586 lines, -0 lines) Patch
A content/browser/resources/media/new/collapse.js View 1 1 chunk +27 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/gen_logs.js View 1 1 chunk +99 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/goog.js View 1 1 chunk +36 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/graph_painter.js View 1 1 chunk +55 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/hover.js View 1 1 chunk +49 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/log_painter.js View 1 1 chunk +70 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/main.js View 1 1 chunk +124 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/media_internals.css View 1 1 chunk +127 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/media_internals.html View 1 1 chunk +133 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/media_internals.js View 1 1 chunk +16 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/number_graph.js View 1 1 chunk +111 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/player_info.js View 1 1 chunk +83 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/player_list_painter.js View 1 1 chunk +48 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/player_manager.js View 1 1 chunk +103 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/property_painter.js View 1 1 chunk +35 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/range_graph.js View 1 1 chunk +141 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/render_manager.js View 1 1 chunk +191 lines, -0 lines 0 comments Download
A content/browser/resources/media/new/table_gen.js View 1 1 chunk +138 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ty Overby
Here's the first UI commit. It is backwards compatible with the messages that are sent ...
7 years, 5 months ago (2013-07-12 22:36:35 UTC) #1
scherkus (not reviewing)
few high level things: - file name format is unix_hacker.js - please add copyright notices ...
7 years, 5 months ago (2013-07-18 02:18:10 UTC) #2
Ty Overby
On 2013/07/18 02:18:10, scherkus wrote: > few high level things: > - file name format ...
7 years, 5 months ago (2013-07-18 16:57:09 UTC) #3
Ty Overby
7 years, 5 months ago (2013-07-18 16:57:16 UTC) #4
https://codereview.chromium.org/18889006/diff/1/content/browser/resources/med...
File content/browser/resources/media/util/goog.js (right):

https://codereview.chromium.org/18889006/diff/1/content/browser/resources/med...
content/browser/resources/media/util/goog.js:5: var goog = {};
On 2013/07/18 02:18:10, scherkus wrote:
> what's the origin of this file?
> 
> is it copied from somewhere?

Kind of.  It uses the same names and sometimes the same code for functions in
the Google Closure Library.  I could probably put them in a 'util' namespace.

Powered by Google App Engine
This is Rietveld 408576698