🙅 Bind a WebAPK to its "host" browser.

Bind a WebAPK to its "host" browser.

WebAPKs are now tied to the host browser which minted them. Introduces a
"runtimeHost" metadata field in the AndroidManifest for WebAPKs to track
parent.

Centralizes logic for retrieving the host browser in a new util class in
webapk common library. Logically this should've been just in the WebAPK
code, but LibraryLoader which is included in the host, can run insides
the WebAPK when initializing a renderer process.

Eventually this will allow us to enforce that only the host browser can
bind to the WebAPK
BUG=524670

[Yaron, 2016-04-15 14:16:26]

yfriedman@chromium.org changed reviewers:
+ hanxi@chromium.org

[Yaron, 2016-04-15 14:16:35]

Description was changed from

==========
Bind a WebAPK's to its "host" browser.

WebAPKs are now tied to the host browser which minted them. Introduces a
"runtimeHost" metadata field in the AndroidManifest for WebAPKs to track
parent.

Centralizes logic for retrieving the host browser in a new util class in
webapk common library. Logically this should've been just in the WebAPK
code, but LibraryLoader which is included in the host, can run insides
the WebAPK when initializing a renderer process.

Eventually this will allow us to enforce that only the host browser can
bind to the WebAPK
BUG=524670
==========

to

==========
Bind a WebAPK to its "host" browser.

WebAPKs are now tied to the host browser which minted them. Introduces a
"runtimeHost" metadata field in the AndroidManifest for WebAPKs to track
parent.

Centralizes logic for retrieving the host browser in a new util class in
webapk common library. Logically this should've been just in the WebAPK
code, but LibraryLoader which is included in the host, can run insides
the WebAPK when initializing a renderer process.

Eventually this will allow us to enforce that only the host browser can
bind to the WebAPK
BUG=524670
==========

[Xi Han, 2016-04-15 14:46:49]

With this patch, no matter which browser launches a WebAPK, the WebAPK always
loads its installed host's dex file, and returns back to its installed host
browser.It does simplify things:)

https://codereview.chromium.org/1888773004/diff/40001/apk_minter/axml-enddec/...
File apk_minter/axml-enddec/src/com/axml/enddec/BinaryXMLParser.java (right):

https://codereview.chromium.org/1888773004/diff/40001/apk_minter/axml-enddec/...
apk_minter/axml-enddec/src/com/axml/enddec/BinaryXMLParser.java:14: private
final byte[] buf;
Do we need these changes?

https://codereview.chromium.org/1888773004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/1888773004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java:249:
private void onOverrideUrlLoadingBackToChrome(String url) {
Rename this function to "onOverrideUrlLoadingBackToHostBrowser". Also, please
update OverrideUrlLoadingResult.OVERRIDE_WITH_INTENT_BACKTO_CHROME and its
description.

https://codereview.chromium.org/1888773004/diff/40001/web_apks/minting_exampl...
File web_apks/minting_example/src/org/chromium/minting/MainActivity.java
(right):

https://codereview.chromium.org/1888773004/diff/40001/web_apks/minting_exampl...
web_apks/minting_example/src/org/chromium/minting/MainActivity.java:104: *
Revert?

https://codereview.chromium.org/1888773004/diff/40001/web_apks/minting_exampl...
web_apks/minting_example/src/org/chromium/minting/MainActivity.java:117: *
Please revert.

[Yaron, 2016-04-15 15:46:58]

https://codereview.chromium.org/1888773004/diff/40001/apk_minter/axml-enddec/...
File apk_minter/axml-enddec/src/com/axml/enddec/BinaryXMLParser.java (right):

https://codereview.chromium.org/1888773004/diff/40001/apk_minter/axml-enddec/...
apk_minter/axml-enddec/src/com/axml/enddec/BinaryXMLParser.java:14: private
final byte[] buf;
On 2016/04/15 14:46:49, Xi Han wrote:
> Do we need these changes?

done automatically by eclipse. I tend to let it do its thing (I have it set up
to do minor cleanups automatically on save) but if it's too distracting, I'll
revert it

https://codereview.chromium.org/1888773004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/1888773004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java:249:
private void onOverrideUrlLoadingBackToChrome(String url) {
On 2016/04/15 14:46:49, Xi Han wrote:
> Rename this function to "onOverrideUrlLoadingBackToHostBrowser". Also, please
> update OverrideUrlLoadingResult.OVERRIDE_WITH_INTENT_BACKTO_CHROME and its
> description.

Done.

https://codereview.chromium.org/1888773004/diff/40001/web_apks/minting_exampl...
File web_apks/minting_example/src/org/chromium/minting/MainActivity.java
(right):

https://codereview.chromium.org/1888773004/diff/40001/web_apks/minting_exampl...
web_apks/minting_example/src/org/chromium/minting/MainActivity.java:104: *
On 2016/04/15 14:46:49, Xi Han wrote:
> Revert?

Done.

https://codereview.chromium.org/1888773004/diff/40001/web_apks/minting_exampl...
web_apks/minting_example/src/org/chromium/minting/MainActivity.java:117: *
On 2016/04/15 14:46:49, Xi Han wrote:
> Please revert.

Done.

[pkotwicz, 2016-04-15 15:51:31]

pkotwicz@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[pkotwicz, 2016-04-15 15:51:31]

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
File web_apks/minting_example/src/org/chromium/minting/DexLoader.java (left):

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
web_apks/minting_example/src/org/chromium/minting/DexLoader.java:30: public
static Context getRemoteContext(Context context, String remotePackageName) {
Drive By: You'll need to update DexLoaderTest.java too

[Yaron, 2016-04-15 15:58:07]

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
File web_apks/minting_example/src/org/chromium/minting/DexLoader.java (left):

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
web_apks/minting_example/src/org/chromium/minting/DexLoader.java:30: public
static Context getRemoteContext(Context context, String remotePackageName) {
On 2016/04/15 15:51:31, pkotwicz wrote:
> Drive By: You'll need to update DexLoaderTest.java too

interesting, i tried building chrome_test_apk and it worked just fine. I guess
it has a dependency on installation but not compilation. will fix, thanks

[Yaron, 2016-04-15 16:12:00]

tests fixed, thanks for the catch

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
File web_apks/minting_example/src/org/chromium/minting/DexLoader.java (left):

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
web_apks/minting_example/src/org/chromium/minting/DexLoader.java:30: public
static Context getRemoteContext(Context context, String remotePackageName) {
On 2016/04/15 15:58:07, Yaron wrote:
> On 2016/04/15 15:51:31, pkotwicz wrote:
> > Drive By: You'll need to update DexLoaderTest.java too
> 
> interesting, i tried building chrome_test_apk and it worked just fine. I guess
> it has a dependency on installation but not compilation. will fix, thanks

oh, it was content_shell_test_apk :)

[Xi Han, 2016-04-15 17:33:04]

lgtm

https://codereview.chromium.org/1888773004/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/1888773004/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:65:
*  an intent to the host browser.*/
It is better to explain the "host browser" is the one that installs the WebAPK.
E.g, "launch an intent to the host browser that installed the WebAPK".

[pkotwicz, 2016-04-15 17:59:43]

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
File
web_apks/minting_example/libs/client/org/chromium/minting/lib/client/NavigationClient.java
(right):

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
web_apks/minting_example/libs/client/org/chromium/minting/lib/client/NavigationClient.java:37:
intent.putExtra(EXTRA_CALLER_PACKAGE_NAME, callerPackageName);
Just checking: You're making use of EXTRA_CALLER_PACKAGE_NAME in a follow up CL?

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
File
web_apks/minting_example/src/org/chromium/minting/MintingServiceFactory.java
(right):

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
web_apks/minting_example/src/org/chromium/minting/MintingServiceFactory.java:52:

Nit: nuke the extraneous new line

https://codereview.chromium.org/1888773004/diff/80001/web_apks/minting_exampl...
File
web_apks/minting_example/libs/common/org/chromium/minting/lib/common/WebAPKUtils.java
(right):

https://codereview.chromium.org/1888773004/diff/80001/web_apks/minting_exampl...
web_apks/minting_example/libs/common/org/chromium/minting/lib/common/WebAPKUtils.java:14:
private static final String DEFAULT_CHROME_PACKAGE_NAME =
"com.google.android.apps.chrome";
Nit: new line

[Yaron, 2016-04-15 21:58:11]

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
File
web_apks/minting_example/libs/client/org/chromium/minting/lib/client/NavigationClient.java
(right):

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
web_apks/minting_example/libs/client/org/chromium/minting/lib/client/NavigationClient.java:37:
intent.putExtra(EXTRA_CALLER_PACKAGE_NAME, callerPackageName);
On 2016/04/15 17:59:43, pkotwicz wrote:
> Just checking: You're making use of EXTRA_CALLER_PACKAGE_NAME in a follow up
CL?

oops. good catch, removed

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
File
web_apks/minting_example/src/org/chromium/minting/MintingServiceFactory.java
(right):

https://codereview.chromium.org/1888773004/diff/60001/web_apks/minting_exampl...
web_apks/minting_example/src/org/chromium/minting/MintingServiceFactory.java:52:

On 2016/04/15 17:59:43, pkotwicz wrote:
> Nit: nuke the extraneous new line

Done.

https://codereview.chromium.org/1888773004/diff/80001/web_apks/minting_exampl...
File
web_apks/minting_example/libs/common/org/chromium/minting/lib/common/WebAPKUtils.java
(right):

https://codereview.chromium.org/1888773004/diff/80001/web_apks/minting_exampl...
web_apks/minting_example/libs/common/org/chromium/minting/lib/common/WebAPKUtils.java:14:
private static final String DEFAULT_CHROME_PACKAGE_NAME =
"com.google.android.apps.chrome";
On 2016/04/15 17:59:43, pkotwicz wrote:
> Nit: new line

Done.