Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: web_apks/minting_example/BUILD.gn

Issue 1888773004: 🙅 Bind a WebAPK to its "host" browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: web_apks/minting_example/BUILD.gn
diff --git a/web_apks/minting_example/BUILD.gn b/web_apks/minting_example/BUILD.gn
index d5a7d8f767d5bb216420fadeba2fd4ea7e3fcced..430a3522004690a5233292cc8b5613663279f24a 100644
--- a/web_apks/minting_example/BUILD.gn
+++ b/web_apks/minting_example/BUILD.gn
@@ -8,6 +8,9 @@ declare_args() {
# The origin URL of minted apks, for example: "foo.com"
manifest_package_minting_origin = "template"
+ # The browser to which WebAPKs will be bound.
+ runtime_host = "com.google.android.apps.chrome"
+
# The URL for the minted apks, for example: "https://foo.com"
host_url = "https://www.template.com/home_page"
scope_url_host = "www.template.com"
@@ -42,6 +45,7 @@ jinja_template("minting_example_manifest") {
"min_sdk_version=16",
"target_sdk_version=23",
"host_url=$host_url",
+ "runtime_host=$runtime_host",
"scope_url_host=$scope_url_host",
"mac=$mac",
"scope=$scope",
@@ -71,7 +75,10 @@ android_library("minting_client_lib") {
}
android_library("minting_common_lib") {
- java_files = [ "$minting_common_dir/org/chromium/minting/lib/common/WebAPKConstants.java" ]
+ java_files = [
+ "$minting_common_dir/org/chromium/minting/lib/common/WebAPKConstants.java",
+ "$minting_common_dir/org/chromium/minting/lib/common/WebAPKUtils.java"
+ ]
}
android_aidl("minting_service_aidl") {
@@ -132,6 +139,7 @@ android_library("web_apk_javatests") {
java_files = [ "$minting_example_dir/javatests/src/org/chromium/minting/DexLoaderTest.java" ]
deps = [
":dex_loader_lib",
+ ":minting_common_lib",
"//base:base_java",
"//content/public/test/android:content_java_test_support",
]

Powered by Google App Engine
This is Rietveld 408576698