Remove MediaControls::bufferingProgressed()

Remove MediaControls::bufferingProgressed()

The implementation just updates the position on the timeline, which
playbackProgressed() already does. This callback would make sense if
buffering progress were actually shown, but until someone implements
that it's cleaner to not have it.

BUG=341813
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168708

[philipj_slow, 2014-03-06 17:47:02]

Just one less thing to deal with when doing the MediaControllerInterface
rewrite...

[acolwell GONE FROM CHROMIUM, 2014-03-06 21:33:51]

lgtm

https://codereview.chromium.org/188853002/diff/1/Source/core/html/shadow/Medi...
File Source/core/html/shadow/MediaControls.cpp (left):

https://codereview.chromium.org/188853002/diff/1/Source/core/html/shadow/Medi...
Source/core/html/shadow/MediaControls.cpp:235:
m_timeline->setPosition(m_mediaController->currentTime());
So we are relying on the playbackStopped() & playbackStarted() calls in
updatePlayState() to update this. It looks like all 'm_paused =' sites except
the one in prepareForLoad() end up calling updatePlayState(). 

ISTM that configureMediaControls() may need a mediaControls()->reset() call in
it so that the control state will get properly reset on prepareForLoad().

https://codereview.chromium.org/188853002/diff/1/Source/core/html/shadow/Medi...
Source/core/html/shadow/MediaControls.cpp:244:
m_timeline->setPosition(m_mediaController->currentTime());
looks like this should just be moved into updateCurrentTimeDisplay() at some
point.

[philipj_slow, 2014-03-07 05:44:08]

https://codereview.chromium.org/188853002/diff/1/Source/core/html/shadow/Medi...
File Source/core/html/shadow/MediaControls.cpp (left):

https://codereview.chromium.org/188853002/diff/1/Source/core/html/shadow/Medi...
Source/core/html/shadow/MediaControls.cpp:235:
m_timeline->setPosition(m_mediaController->currentTime());
On 2014/03/06 21:33:51, acolwell wrote:
> So we are relying on the playbackStopped() & playbackStarted() calls in
> updatePlayState() to update this. It looks like all 'm_paused =' sites except
> the one in prepareForLoad() end up calling updatePlayState(). 
> 
> ISTM that configureMediaControls() may need a mediaControls()->reset() call in
> it so that the control state will get properly reset on prepareForLoad().

Good catch! I was able to trigger this bug even without this patch by simply
removing src/source and calling load() after playback has begun. Sometimes, the
time display is not updated. Since this is a pre-existing bug, I'll fix it in a
separate CL.

https://codereview.chromium.org/188853002/diff/1/Source/core/html/shadow/Medi...
Source/core/html/shadow/MediaControls.cpp:244:
m_timeline->setPosition(m_mediaController->currentTime());
On 2014/03/06 21:33:51, acolwell wrote:
> looks like this should just be moved into updateCurrentTimeDisplay() at some
> point.

Yeah, making updateCurrentTimeDisplay() into something that's called whenever a
timeupdate event would be fired and moving this in would be nice. The first part
of that plan is blocked by a FIXME in prepareForLoad() though: "FIXME: Add
support for firing this event."

[philipj_slow, 2014-03-07 05:44:13]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-03-07 05:44:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/188853002/1

[commit-bot: I haz the power, 2014-03-07 06:24:28]

Change committed as 168708