Remove MediaControls::bufferingProgressed()

Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 209 matching lines @@
 void MediaControls::makeTransparent()
 {
     m_panel->makeTransparent();
 }
 
 bool MediaControls::shouldHideControls()
 {
     return !m_panel->hovered();
 }
 
-void MediaControls::bufferingProgressed()
-{
-    // We only need to update buffering progress when paused, during normal
-    // playback playbackProgressed() will take care of it.
-    if (m_mediaController->paused())
-        m_timeline->setPosition(m_mediaController->currentTime());

[acolwell GONE FROM CHROMIUM, 2014/03/06 21:33:51]

So we are relying on the playbackStopped() & playbackStarted() calls in
updatePlayState() to update this. It looks like all 'm_paused =' sites except
the one in prepareForLoad() end up calling updatePlayState(). 

ISTM that configureMediaControls() may need a mediaControls()->reset() call in
it so that the control state will get properly reset on prepareForLoad().

[philipj_slow, 2014/03/07 05:44:09]

Good catch! I was able to trigger this bug even without this patch by simply
removing src/source and calling load() after playback has begun. Sometimes, the
time display is not updated. Since this is a pre-existing bug, I'll fix it in a
separate CL.

-}
-
 void MediaControls::playbackStarted()
 {
     m_currentTimeDisplay->show();
     m_durationDisplay->hide();
 
     m_playButton->updateDisplayType();
     m_timeline->setPosition(m_mediaController->currentTime());

[acolwell GONE FROM CHROMIUM, 2014/03/06 21:33:51]

looks like this should just be moved into updateCurrentTimeDisplay() at some
point.

[philipj_slow, 2014/03/07 05:44:09]

Yeah, making updateCurrentTimeDisplay() into something that's called whenever a
timeupdate event would be fired and moving this in would be nice. The first part
of that plan is blocked by a FIXME in prepareForLoad() though: "FIXME: Add
support for firing this event."

     updateCurrentTimeDisplay();
 
     if (m_isFullscreen)
         startHideFullscreenControlsTimer();
 }
 
 void MediaControls::playbackProgressed()
 {
     m_timeline->setPosition(m_mediaController->currentTime());
     updateCurrentTimeDisplay();
@@ skipping 199 matching lines @@
     m_textDisplayContainer->updateDisplay();
 }
 
 void MediaControls::insertTextTrackContainer(PassRefPtr<MediaControlTextTrackContainerElement> textTrackContainer)
 {
     // Insert it before the first controller element so it always displays behind the controls.
     insertBefore(textTrackContainer, m_enclosure);
 }
 
 }