src/gpu/gl/GrGLCaps.cpp - Issue 1888473002: Use transfer buffer for BatchAtlas texture copies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLCaps.cpp

Issue 1888473002: Use transfer buffer for BatchAtlas texture copies Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix Chrome Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/GrGLCaps.cpp

diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp

index f3e494acb90cfd2e1d1fd8003dd18ba395357988..abf2cb7d567a330597b500b753fc388c10499bc1 100644

--- a/src/gpu/gl/GrGLCaps.cpp

+++ b/src/gpu/gl/GrGLCaps.cpp

@@ -393,8 +393,9 @@ void GrGLCaps::init(const GrContextOptions& contextOptions,

} else {

if (version >= GR_GL_VER(3, 0) || ctxInfo.hasExtension("GL_NV_pixel_buffer_object")) {

fTransferBufferType = kPBO_TransferBufferType;

- } else if (ctxInfo.hasExtension("GL_CHROMIUM_pixel_transfer_buffer_object")) {

- fTransferBufferType = kChromium_TransferBufferType;

+// TODO: get transfer buffers working in Chrome

+// } else if (ctxInfo.hasExtension("GL_CHROMIUM_pixel_transfer_buffer_object")) {

+// fTransferBufferType = kChromium_TransferBufferType;

}