Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1888453009: Revert of Add the missing text input state tracking code to RenderWidgetHostViewMac. (Closed)

Created:
4 years, 8 months ago by EhsanK
Modified:
4 years, 8 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Revert of Add the missing text input state tracking code to RenderWidgetHostViewMac. (patchset #1 id:1 of https://codereview.chromium.org/1880223002/ ) Reason for revert: This is needed to revert https://codereview.chromium.org/1652483002/. The original CL caused many regressions. BUG=601738, 601570, 602144, 602954, 603209, 603676, 603886, 602926, 602488 Original issue's description: > Add the missing text input state tracking code to RenderWidgetHostViewMac. > > Following the fix for crbug.com/578167 (CL 1652483002), a small part of > the Mac related code was removed due to bad merging (after Patch 7). > This CL fixes the issue by storing the new values of text input state in > RenderWidgetHostViewMac as reported by the WebContentsImpl. > > BUG=601738 > NOTRY=true > NOPRESUBMIT=true > > Review URL: https://codereview.chromium.org/1878523002 > > Cr-Commit-Position: refs/heads/master@{#386504} > (cherry picked from commit 46248c7ed4872cffc4ebb0b9da458678f7d7e7a3) TBR=creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=601738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
EhsanK
Created Revert of Add the missing text input state tracking code to RenderWidgetHostViewMac.
4 years, 8 months ago (2016-04-15 19:30:54 UTC) #1
Charlie Reis
This one's on the M51 branch. Lucas mentioned that the plan is to revert this ...
4 years, 8 months ago (2016-04-15 20:49:53 UTC) #2
EhsanK
4 years, 8 months ago (2016-04-22 19:15:04 UTC) #3
On 2016/04/15 20:49:53, Charlie Reis wrote:
> This one's on the M51 branch.  Lucas mentioned that the plan is to revert this
+
> the original CL from branch after we make sure everything is back to normal on
> Canary (after https://codereview.chromium.org/1889313002/), right?

Closing this CL in favor of https://codereview.chromium.org/1889313002/ which
has already landed.

Powered by Google App Engine
This is Rietveld 408576698