Add the missing text input state tracking code to RenderWidgetHostViewMac.

Add the missing text input state tracking code to RenderWidgetHostViewMac.

Following the fix for crbug.com/578167 (CL 1652483002), a small part of
the Mac related code was removed due to bad merging (after Patch 7).
This CL fixes the issue by storing the new values of text input state in
RenderWidgetHostViewMac as reported by the WebContentsImpl.

BUG=601738
Committed: https://crrev.com/46248c7ed4872cffc4ebb0b9da458678f7d7e7a3
Cr-Commit-Position: refs/heads/master@{#386504}

[EhsanK, 2016-04-11 05:27:00]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-11 05:27:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878523002/1

[commit-bot: I haz the power, 2016-04-11 06:08:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 06:08:27]

Dry run: This issue passed the CQ dry run.

[EhsanK, 2016-04-11 06:44:53]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org

[EhsanK, 2016-04-11 06:44:53]

PTAL.

This was due to a blatant mistake I made in merging somewhere after patch 7 of
the text input state cl 1652483002. What was happening was that RWHVMac was not
using the updating input state.

[Charlie Reis, 2016-04-11 20:13:34]

LGTM.

Is there a test that could have caught this regression?  Feel free to land the
regression fix first, but since this sounds pretty bad, it's important to have a
test for it.

You'll likely need to merge this to M51 as well, since we've just branched.

https://codereview.chromium.org/1878523002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/1878523002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:1019: // these
local variables.
s/local variables/members/
(Or do I misunderstand what you're planning?)

Please file a bug for this and list the number in this TODO, since I'm concerned
about having the state tracked in more than one place.  We should get it cleaned
up soon.

[EhsanK, 2016-04-11 20:31:08]

On 2016/04/11 20:13:34, Charlie Reis wrote:
> LGTM.
> 
> Is there a test that could have caught this regression?  Feel free to land the
> regression fix first, but since this sounds pretty bad, it's important to have
a
> test for it.
> 
> You'll likely need to merge this to M51 as well, since we've just branched.
> 
>
https://codereview.chromium.org/1878523002/diff/1/content/browser/renderer_ho...
> File content/browser/renderer_host/render_widget_host_view_mac.mm (right):
> 
>
https://codereview.chromium.org/1878523002/diff/1/content/browser/renderer_ho...
> content/browser/renderer_host/render_widget_host_view_mac.mm:1019: // these
> local variables.
> s/local variables/members/
> (Or do I misunderstand what you're planning?)
> 
> Please file a bug for this and list the number in this TODO, since I'm
concerned
> about having the state tracked in more than one place.  We should get it
cleaned
> up soon.

I am surprised no tests broke. This was not a small miss. I am taking a look at
OOPIF IME in general. I will see if there are tests or ways to test these
issues.

> Please file a bug for this and list the number in this TODO, since I'm
concerned
> about having the state tracked in more than one place.  We should get it
cleaned
> up soon

Yes. Another place to clean up is BrowsePluginGuest.

[EhsanK, 2016-04-11 20:45:19]

The CQ bit was checked by ekaramad@chromium.org

[EhsanK, 2016-04-11 20:45:19]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/1878523002/#ps20001
(title: "Added a bug number to TODO.")

[commit-bot: I haz the power, 2016-04-11 20:45:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878523002/20001

[EhsanK, 2016-04-11 20:46:01]

Thanks for the reviews. I will also file a bug to find/create a test for IME.

https://codereview.chromium.org/1878523002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/1878523002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:1019: // these
local variables.
On 2016/04/11 20:13:34, Charlie Reis wrote:
> s/local variables/members/
> (Or do I misunderstand what you're planning?)
> 
> Please file a bug for this and list the number in this TODO, since I'm
concerned
> about having the state tracked in more than one place.  We should get it
cleaned
> up soon.

You are right. Members.

[Robert Sesek, 2016-04-11 20:58:11]

Description was changed from

==========
Add the missing text input state tracking code to RenderWidgetHostViewMac.

Following the fix for crbug.com/578167 (CL 1652483002), a small part of
the MAC related code was removed due to bad merging (after Patch 7).
This CL fixes the issue by storing the new values of text input state in
RenderWidgetHostViewMac as reported by the WebContentsImpl.

BUG=601738
==========

to

==========
Add the missing text input state tracking code to RenderWidgetHostViewMac.

Following the fix for crbug.com/578167 (CL 1652483002), a small part of
the Mac related code was removed due to bad merging (after Patch 7).
This CL fixes the issue by storing the new values of text input state in
RenderWidgetHostViewMac as reported by the WebContentsImpl.

BUG=601738
==========

[commit-bot: I haz the power, 2016-04-11 22:56:22]

Description was changed from

==========
Add the missing text input state tracking code to RenderWidgetHostViewMac.

Following the fix for crbug.com/578167 (CL 1652483002), a small part of
the Mac related code was removed due to bad merging (after Patch 7).
This CL fixes the issue by storing the new values of text input state in
RenderWidgetHostViewMac as reported by the WebContentsImpl.

BUG=601738
==========

to

==========
Add the missing text input state tracking code to RenderWidgetHostViewMac.

Following the fix for crbug.com/578167 (CL 1652483002), a small part of
the Mac related code was removed due to bad merging (after Patch 7).
This CL fixes the issue by storing the new values of text input state in
RenderWidgetHostViewMac as reported by the WebContentsImpl.

BUG=601738
==========

[commit-bot: I haz the power, 2016-04-11 22:56:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-11 22:57:41]

Description was changed from

==========
Add the missing text input state tracking code to RenderWidgetHostViewMac.

Following the fix for crbug.com/578167 (CL 1652483002), a small part of
the Mac related code was removed due to bad merging (after Patch 7).
This CL fixes the issue by storing the new values of text input state in
RenderWidgetHostViewMac as reported by the WebContentsImpl.

BUG=601738
==========

to

==========
Add the missing text input state tracking code to RenderWidgetHostViewMac.

Following the fix for crbug.com/578167 (CL 1652483002), a small part of
the Mac related code was removed due to bad merging (after Patch 7).
This CL fixes the issue by storing the new values of text input state in
RenderWidgetHostViewMac as reported by the WebContentsImpl.

BUG=601738

Committed: https://crrev.com/46248c7ed4872cffc4ebb0b9da458678f7d7e7a3
Cr-Commit-Position: refs/heads/master@{#386504}
==========

[commit-bot: I haz the power, 2016-04-11 22:57:42]

Patchset 2 (id:??) landed as
https://crrev.com/46248c7ed4872cffc4ebb0b9da458678f7d7e7a3
Cr-Commit-Position: refs/heads/master@{#386504}

[EhsanK, 2016-04-15 19:21:16]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1883293006/ by ekaramad@chromium.org.

The reason for reverting is: This is needed to revert 
https://codereview.chromium.org/1652483002/. The original CL caused many
regressions.
.