Issue 1888453005: [Blob] Better error reporting and histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1888453005: [Blob] Better error reporting and histograms. (Closed)

Created:
4 years, 8 months ago by dmurph

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

[Blob] Better error reporting and histograms. The UMA for renderer crashes due to invalid blob messages is rather high. I'm adding better error reporting to figure out the issue. BUG=602443 Review URL: https://codereview.chromium.org/1875223002 Cr-Commit-Position: refs/heads/master@{#386754} (cherry picked from commit 907439e58214fcdf4759296655ce650ad4f0eb86) Committed: https://chromium.googlesource.com/chromium/src/+/f236d16d5b2484d5f724afed48044d04659f07b3

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -11 lines)			Patch
M	content/browser/bad_message.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/blob_storage/blob_dispatcher_host.cc	View	6 chunks	+12 lines, -7 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	3 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

dmurph

4 years, 8 months ago (2016-04-14 19:43:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f236d16d5b2484d5f724afed48044d04659f07b3.