Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1875223002: [Blob] Better error reporting and histograms. (Closed)

Created:
4 years, 8 months ago by dmurph
Modified:
4 years, 8 months ago
Reviewers:
kinuko, Mark P
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blob] Better error reporting and histograms. The UMA for renderer crashes due to invalid blob messages is rather high. I'm adding better error reporting to figure out the issue. BUG=602443 Committed: https://crrev.com/907439e58214fcdf4759296655ce650ad4f0eb86 Cr-Commit-Position: refs/heads/master@{#386754}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M content/browser/bad_message.h View 1 chunk +2 lines, -1 line 1 comment Download
M content/browser/blob_storage/blob_dispatcher_host.cc View 6 chunks +12 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dmurph
Hi Mark & Kinuko! I'm trying to add better error reporting so that I can ...
4 years, 8 months ago (2016-04-11 21:22:27 UTC) #3
Mark P
What you're doing with the enum is, metrics-wise, a bit of a mess. You'll have ...
4 years, 8 months ago (2016-04-11 21:32:39 UTC) #4
Mark P
histograms.xml lgtm / approval on condition that you get this merged with the change that ...
4 years, 8 months ago (2016-04-11 23:17:41 UTC) #5
kinuko
lgtm if Mark is fine with the histogram change
4 years, 8 months ago (2016-04-12 05:09:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875223002/1
4 years, 8 months ago (2016-04-12 17:40:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 18:46:33 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 18:47:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/907439e58214fcdf4759296655ce650ad4f0eb86
Cr-Commit-Position: refs/heads/master@{#386754}

Powered by Google App Engine
This is Rietveld 408576698