Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 188843003: Revert 255368 "Clean up WindowEventDispatcher some more." (Closed)

Created:
6 years, 9 months ago by Ben Goodger (Google)
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 255368 "Clean up WindowEventDispatcher some more." > Clean up WindowEventDispatcher some more. > > . Eliminate the implementation of LayerAnimationObserver. It seems no one expects WED to be a LAO anymore. > . Remove WindowTreeHostDelegate. This involves moving some of the functions to WTH, removing some completely, and moving the remainder to the WED public API. A little icky for now, but I plan to take a pass on cleaning up WED's public API once I get it pared down. > . window_tree_host_x11_unittest provided an implementation of WTHD that was not WED. This is not a valid situation now since various functions in WTH now call directly through to WED. Replaced this with a simple EventHandler to test that events are being dispatched. > > R=sky@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/188223002 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -198 lines) Patch
M trunk/src/ash/cancel_mode.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/cancel_mode.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/first_run/desktop_cleaner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/sticky_keys/sticky_keys_overlay_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ash/sticky_keys/sticky_keys_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ash/wm/overview/window_overview.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/mojo/examples/aura_demo/window_tree_host_mojo.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/ui/app_list/views/app_list_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/aura/aura.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/aura/remote_window_tree_host_win.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/aura/remote_window_tree_host_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ui/aura/window_event_dispatcher.h View 7 chunks +30 lines, -9 lines 0 comments Download
M trunk/src/ui/aura/window_event_dispatcher.cc View 6 chunks +92 lines, -39 lines 0 comments Download
M trunk/src/ui/aura/window_event_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/aura/window_tree_host.h View 5 chunks +9 lines, -2 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host.cc View 10 chunks +28 lines, -31 lines 0 comments Download
A + trunk/src/ui/aura/window_tree_host_delegate.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/aura/window_tree_host_win.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/aura/window_tree_host_x11.cc View 9 chunks +17 lines, -13 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_x11_unittest.cc View 8 chunks +106 lines, -71 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 6 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
6 years, 9 months ago (2014-03-06 18:09:21 UTC) #1
Ben Goodger (Google)
6 years, 9 months ago (2014-03-06 18:11:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r255399 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698