Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1888183003: move track_audio_renderer.{cc,h} to private_renderer_webrtc_sources (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

move track_audio_renderer.{cc,h} to private_renderer_webrtc_sources This unbreaks the no-webrtc build after https://codereview.chromium.org/1891183002 BUG=596174 Committed: https://crrev.com/374367f4db56082237201e8163ed1156a69d9805 Cr-Commit-Position: refs/heads/master@{#387688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/content_renderer.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888183003/1
4 years, 8 months ago (2016-04-15 18:12:22 UTC) #2
Mostyn Bramley-Moore
@tommi, o1ka: please take a look at this fixup for https://codereview.chromium.org/1891183002/
4 years, 8 months ago (2016-04-15 18:12:28 UTC) #4
tommi (sloooow) - chröme
lgtm
4 years, 8 months ago (2016-04-15 18:49:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 19:06:23 UTC) #7
o1ka
lgtm
4 years, 8 months ago (2016-04-15 19:08:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888183003/1
4 years, 8 months ago (2016-04-15 20:07:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 20:12:31 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 20:13:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/374367f4db56082237201e8163ed1156a69d9805
Cr-Commit-Position: refs/heads/master@{#387688}

Powered by Google App Engine
This is Rietveld 408576698