Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: content/browser/renderer_host/input/input_router_impl.cc

Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modify PlatformTouchEvent and address comments in patch set 1 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/input_router_impl.cc
diff --git a/content/browser/renderer_host/input/input_router_impl.cc b/content/browser/renderer_host/input/input_router_impl.cc
index 598e21747a928a468ffb9f3af15e7bbbcd347c06..bc1513e780fc3f90ca6a31f3922c8f7fb45fe844 100644
--- a/content/browser/renderer_host/input/input_router_impl.cc
+++ b/content/browser/renderer_host/input/input_router_impl.cc
@@ -369,8 +369,6 @@ void InputRouterImpl::OfferToHandlers(const WebInputEvent& input_event,
if (OfferToClient(input_event, latency_info))
return;
- // Touch events should always indicate in the event whether they are
- // cancelable (respect ACK disposition) or not except touchmove.
bool should_block = WebInputEventTraits::ShouldBlockEventStream(input_event);
OfferToRenderer(input_event, latency_info,
@@ -378,12 +376,6 @@ void InputRouterImpl::OfferToHandlers(const WebInputEvent& input_event,
? InputEventDispatchType::DISPATCH_TYPE_BLOCKING
: InputEventDispatchType::DISPATCH_TYPE_NON_BLOCKING);
- if (WebInputEvent::isTouchEventType(input_event.type) &&
- input_event.type != WebInputEvent::TouchMove) {
- const WebTouchEvent& touch = static_cast<const WebTouchEvent&>(input_event);
- DCHECK_EQ(should_block, touch.cancelable);
- }
-
// Generate a synthetic ack if the event was sent so it doesn't block.
if (!should_block) {
ProcessInputEventAck(

Powered by Google App Engine
This is Rietveld 408576698