components/test_runner/event_sender.cc - Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/event_sender.cc

Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modify PlatformTouchEvent and address comments in patch set 1 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/event_sender.cc

diff --git a/components/test_runner/event_sender.cc b/components/test_runner/event_sender.cc

index 58b8f1c179ad0271b0cfa6f2f8d1e08f2af055dd..a09a8b56154eab6f8a84fec625053bc8fbd5e062 100644

--- a/components/test_runner/event_sender.cc

+++ b/components/test_runner/event_sender.cc

@@ -2160,7 +2160,8 @@ void EventSender::SendCurrentTouchEvent(WebInputEvent::Type type,

WebTouchEvent touch_event;

touch_event.type = type;

touch_event.modifiers = touch_modifiers_;

- touch_event.cancelable = touch_cancelable_;

+ touch_event.dispatchType = touch_cancelable_ ? WebInputEvent::EventNonBlocking

+ : WebInputEvent::Blocking;

touch_event.timeStampSeconds = GetCurrentEventTimeSec();

touch_event.movedBeyondSlopRegion = movedBeyondSlopRegion;

touch_event.touchesLength = touch_points_.size();

« no previous file with comments | « no previous file | content/browser/renderer_host/input/input_router_impl.cc » ('j') | content/common/input/web_input_event_traits.cc » ('J')