Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1888153002: WorkspaceLayoutManagerDelegate -> WorkspaceLayoutManagerBackdropDelegate (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WorkspaceLayoutManagerDelegate -> WorkspaceLayoutManagerBackdropDelegate And adds a WorkspaceLayoutManagerDelegate that is used for fullscreen and shelf state. I suspect mash won't use ShelfLayoutManager and mash won't use ash::Shell. WorkspaceLayoutManagerDelegate is intended to provide said functionality. BUG=603369 TEST=covered by tests R=oshima@chromium.org Committed: https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b Cr-Commit-Position: refs/heads/master@{#387427}

Patch Set 1 #

Total comments: 3

Patch Set 2 : =default and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -102 lines) Patch
M ash/ash.gyp View 8 chunks +11 lines, -10 lines 0 comments Download
M ash/root_window_controller.cc View 1 6 chunks +38 lines, -3 lines 0 comments Download
M ash/wm/always_on_top_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/always_on_top_controller_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
A ash/wm/common/workspace/workspace_layout_manager_delegate.h View 1 chunk +27 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/workspace_backdrop_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 4 chunks +11 lines, -7 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 5 chunks +14 lines, -13 lines 0 comments Download
A + ash/wm/workspace/workspace_layout_manager_backdrop_delegate.h View 3 chunks +6 lines, -6 lines 0 comments Download
D ash/wm/workspace/workspace_layout_manager_delegate.h View 1 chunk +0 lines, -49 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller.h View 2 chunks +8 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller.cc View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
https://codereview.chromium.org/1888153002/diff/1/ash/ash.gyp File ash/ash.gyp (right): https://codereview.chromium.org/1888153002/diff/1/ash/ash.gyp#newcode76 ash/ash.gyp:76: 'display/display_configuration_controller.cc', Sorry for the reordering. I ran tools/git/mass_rename, which ...
4 years, 8 months ago (2016-04-14 17:59:58 UTC) #1
oshima
lgtm https://codereview.chromium.org/1888153002/diff/1/ash/ash.gyp File ash/ash.gyp (right): https://codereview.chromium.org/1888153002/diff/1/ash/ash.gyp#newcode76 ash/ash.gyp:76: 'display/display_configuration_controller.cc', On 2016/04/14 17:59:58, sky wrote: > Sorry ...
4 years, 8 months ago (2016-04-14 19:12:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888153002/20001
4 years, 8 months ago (2016-04-14 20:26:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 21:19:26 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 21:22:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b
Cr-Commit-Position: refs/heads/master@{#387427}

Powered by Google App Engine
This is Rietveld 408576698