Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1888083002: Revert of UTF-8 detector for pages missing encoding info (Closed)

Created:
4 years, 8 months ago by rnephew (Reviews Here)
Modified:
4 years, 8 months ago
CC:
aelias_OOO_until_Jul13, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of UTF-8 detector for pages missing encoding info (patchset #12 id:210001 of https://codereview.chromium.org/1721373002/ ) Reason for revert: Causes jetstream perf test to fail. crbug.com/603558 Original issue's description: > UTF-8 detector for pages missing encoding info > > Experiment crbug.com/518968 shows that about 30% of the pages > missing character encoding information are encoded in UTF-8. > This CL runs a quick one-pass scan against them to check if > they are encoded in UTF-8. It helps get the encoding right > for 30% of the pages without having to turn on full auto-encoding > detection logic which is disabled due to slow performance. > > BUG=583549 > TEST=Layout test: fast/encoding/unlabelled-non-ascii-utf8.html > > Committed: https://crrev.com/2af3917eb9ca14b263116d664a8257ae69680610 > Cr-Commit-Position: refs/heads/master@{#387209} TBR=esprehn@chromium.org,aelias@chromium.org,jshin@chromium.org,tkent@chromium.org,jinsukkim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583549 Committed: https://crrev.com/c2a71296a5ad867ce0ff5d0dffbe736419044666 Cr-Commit-Position: refs/heads/master@{#387332}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
rnephew (Reviews Here)
Created Revert of UTF-8 detector for pages missing encoding info
4 years, 8 months ago (2016-04-14 16:15:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888083002/1
4 years, 8 months ago (2016-04-14 16:15:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 16:16:29 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 16:18:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2a71296a5ad867ce0ff5d0dffbe736419044666
Cr-Commit-Position: refs/heads/master@{#387332}

Powered by Google App Engine
This is Rietveld 408576698