Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 1888043006: Revert of Migrate FastCloneShallowObjectStub to TurboFan (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Migrate FastCloneShallowObjectStub to TurboFan (patchset #9 id:180001 of https://codereview.chromium.org/1838283003/ ) Reason for revert: The boilerplate is copied based on the boilerplate + memento size, which reads off the end of the boilerplate. Original issue's description: > Migrate FastCloneShallowObjectStub to TurboFan > > BUG= > > Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924 > Cr-Commit-Position: refs/heads/master@{#35330} > > Committed: https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9 > Cr-Commit-Position: refs/heads/master@{#35494} TBR=bmeurer@chromium.org,jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a369f4a39f96a656329dd8740fab4f93690c19b4 Cr-Commit-Position: refs/heads/master@{#35544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -107 lines) Patch
M src/code-stubs.h View 3 chunks +9 lines, -8 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +8 lines, -76 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Toon Verwaest
Created Revert of Migrate FastCloneShallowObjectStub to TurboFan
4 years, 8 months ago (2016-04-15 19:36:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888043006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888043006/1
4 years, 8 months ago (2016-04-15 19:36:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888043006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888043006/1
4 years, 8 months ago (2016-04-15 20:02:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888043006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888043006/1
4 years, 8 months ago (2016-04-15 20:06:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 20:06:34 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 20:08:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a369f4a39f96a656329dd8740fab4f93690c19b4
Cr-Commit-Position: refs/heads/master@{#35544}

Powered by Google App Engine
This is Rietveld 408576698