Migrate FastCloneShallowObjectStub to TurboFan

Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}

Committed: https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9
Cr-Commit-Position: refs/heads/master@{#35494}

Committed: https://crrev.com/5325379982015b5becb8c1f56b1797dd36a57942
Cr-Commit-Position: refs/heads/master@{#35563}

[Toon Verwaest, 2016-03-30 15:11:01]

verwaest@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Toon Verwaest, 2016-03-30 15:11:02]

wip, ptal for initial feedback

https://codereview.chromium.org/1838283003/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1838283003/diff/1/src/code-stubs.cc#newcode3055
src/code-stubs.cc:3055: Node* copy = assembler->Allocate(size);
This trashes the context register if it calls the runtime. The caller of this
stub isn't very happy about that... How should I solve this?

https://codereview.chromium.org/1838283003/diff/1/src/code-stubs.cc#newcode3061
src/code-stubs.cc:3061: Node* field = assembler->LoadObjectField(boilerplate,
i);
I guess I should use a different load instruction that loads a raw word.

https://codereview.chromium.org/1838283003/diff/1/src/code-stubs.cc#newcode3062
src/code-stubs.cc:3062: assembler->StoreObjectFieldNoWriteBarrier(copy, i,
field);
And probably the same for storing it...

[Benedikt Meurer, 2016-03-30 17:12:35]

It'd be nice to have a stub that we can use from Ignition.

https://codereview.chromium.org/1838283003/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1838283003/diff/1/src/code-stubs.cc#newcode3055
src/code-stubs.cc:3055: Node* copy = assembler->Allocate(size);
This is fine (and true for essentially all TurboFan code stubs). We need to fix
call sites in FCG to reload the context register.

https://codereview.chromium.org/1838283003/diff/1/src/code-stubs.cc#newcode3061
src/code-stubs.cc:3061: Node* field = assembler->LoadObjectField(boilerplate,
i);
Yes, something like LoadRawPointer/StoreRawPointer or something like that.

[Toon Verwaest, 2016-04-05 14:37:21]

PTAL. I updated the machinetype / representation passed in to the load / store.
I kept the allocation memento since I want to minimize the risk.

[Benedikt Meurer, 2016-04-06 17:20:36]

https://codereview.chromium.org/1838283003/diff/100001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1838283003/diff/100001/src/code-stubs.cc#newc...
src/code-stubs.cc:3096: assembler->Branch(assembler->WordEqual(allocation_site,
undefined),
Use GotoIf.

https://codereview.chromium.org/1838283003/diff/100001/src/code-stubs.cc#newc...
src/code-stubs.cc:3118: assembler->Branch(assembler->Word32Equal(instance_size,
size_in_words),
Use GotoIf.

https://codereview.chromium.org/1838283003/diff/100001/src/full-codegen/x64/f...
File src/full-codegen/x64/full-codegen-x64.cc (right):

https://codereview.chromium.org/1838283003/diff/100001/src/full-codegen/x64/f...
src/full-codegen/x64/full-codegen-x64.cc:1386: __ Pop(rsi);
No need to push/pop the context, just reload it from the frame.

[Toon Verwaest, 2016-04-07 05:45:13]

Patchset #7 (id:120001) has been deleted

[Toon Verwaest, 2016-04-07 05:46:13]

addressed comments, ptal again

[Benedikt Meurer, 2016-04-07 09:18:44]

lgtm

[Toon Verwaest, 2016-04-07 09:18:53]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-04-07 09:18:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838283003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838283003/140001

[commit-bot: I haz the power, 2016-04-07 09:53:37]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-04-07 09:54:22]

Description was changed from

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=
==========

to

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}
==========

[commit-bot: I haz the power, 2016-04-07 09:54:23]

Patchset 7 (id:??) landed as
https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}

[Michael Hablich, 2016-04-08 11:01:39]

A revert of this CL (patchset #7 id:140001) has been created in
https://codereview.chromium.org/1875683002/ by hablich@chromium.org.

The reason for reverting is: Makes some WebGL tests flaky:
https://codereview.chromium.org/1866373002/

Bisection on tryserver shows this as the culprit. Local repro unfortunately does
not work..

[Toon Verwaest, 2016-04-14 12:03:22]

Description was changed from

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}
==========

to

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}
==========

[Toon Verwaest, 2016-04-14 13:06:35]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-04-14 13:06:35]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1838283003/#ps180001
(title: " ")

[commit-bot: I haz the power, 2016-04-14 13:06:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838283003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838283003/180001

[commit-bot: I haz the power, 2016-04-14 13:29:44]

Description was changed from

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}
==========

to

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}
==========

[commit-bot: I haz the power, 2016-04-14 13:29:45]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2016-04-14 13:30:34]

Description was changed from

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}
==========

to

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}

Committed: https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9
Cr-Commit-Position: refs/heads/master@{#35494}
==========

[commit-bot: I haz the power, 2016-04-14 13:30:35]

Patchset 9 (id:??) landed as
https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9
Cr-Commit-Position: refs/heads/master@{#35494}

[Jakob Kummerow, 2016-04-15 17:20:53]

jkummerow@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2016-04-15 17:20:55]

https://codereview.chromium.org/1838283003/diff/180001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1838283003/diff/180001/src/code-stubs.cc#newc...
src/code-stubs.cc:3665: for (int i = 0; i < size; i += kPointerSize) {
This should be "i < object_size"! Otherwise we'll copy beyond the end of the
boilerplate (which doesn't have an AllocationMemento behind it), which may well
mean copying outside the current page.

Suggestion: rename "int size" to "int allocation_size" to make the distinction
more obvious.

[Toon Verwaest, 2016-04-15 19:36:10]

A revert of this CL (patchset #9 id:180001) has been created in
https://codereview.chromium.org/1888043006/ by verwaest@chromium.org.

The reason for reverting is: The boilerplate is copied based on the boilerplate
+ memento size, which reads off the end of the boilerplate..

[Toon Verwaest, 2016-04-18 07:34:37]

ptal again

[Toon Verwaest, 2016-04-18 07:34:42]

Description was changed from

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}

Committed: https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9
Cr-Commit-Position: refs/heads/master@{#35494}
==========

to

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}

Committed: https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9
Cr-Commit-Position: refs/heads/master@{#35494}
==========

[Benedikt Meurer, 2016-04-18 07:42:52]

lgtm

[Toon Verwaest, 2016-04-18 07:44:33]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-04-18 07:44:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838283003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838283003/220001

[commit-bot: I haz the power, 2016-04-18 08:11:54]

Description was changed from

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}

Committed: https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9
Cr-Commit-Position: refs/heads/master@{#35494}
==========

to

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}

Committed: https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9
Cr-Commit-Position: refs/heads/master@{#35494}
==========

[commit-bot: I haz the power, 2016-04-18 08:11:55]

Committed patchset #11 (id:220001)

[commit-bot: I haz the power, 2016-04-18 08:14:05]

Description was changed from

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}

Committed: https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9
Cr-Commit-Position: refs/heads/master@{#35494}
==========

to

==========
Migrate FastCloneShallowObjectStub to TurboFan

BUG=

Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924
Cr-Commit-Position: refs/heads/master@{#35330}

Committed: https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9
Cr-Commit-Position: refs/heads/master@{#35494}

Committed: https://crrev.com/5325379982015b5becb8c1f56b1797dd36a57942
Cr-Commit-Position: refs/heads/master@{#35563}
==========

[commit-bot: I haz the power, 2016-04-18 08:14:07]

Patchset 11 (id:??) landed as
https://crrev.com/5325379982015b5becb8c1f56b1797dd36a57942
Cr-Commit-Position: refs/heads/master@{#35563}