Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1887953002: Revert of [Merge to M50] Enable bootstrapping feature by default. (Closed)

Created:
4 years, 8 months ago by Wez
Modified:
4 years, 8 months ago
Reviewers:
xdai1
CC:
chromium-reviews, extensions-reviews_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org, ketakid1
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Revert of [Merge to M50] Enable bootstrapping feature by default. (patchset #1 id:1 of https://codereview.chromium.org/1875363002/ ) Reason for revert: Appears to have broken PFQ for M50. Reverting at request of ketakid@. Original issue's description: > [Merge to M50] Enable bootstrapping feature by default. > > Currently it was kept disabled behind a command switch --oobe-bootstrapping-slave. > > BUG=597039 > TBR=dzhioev@chromium.org, achuith@chromium.org, emaxx@chromium.org > > Review URL: https://codereview.chromium.org/1829453002 > > Cr-Commit-Position: refs/heads/master@{#383764} > (cherry picked from commit cfe59845e307f126b25d555ef576e2968aa5d7b9) > > Committed: https://chromium.googlesource.com/chromium/src/+/086d377e0758cfdf3976985616f3afaf9940f1a9 TBR=xdai@chromium.org NOPRESUBMIT=true NOTRY=true BUG=597039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -80 lines) Patch
M chrome/app/chromeos_strings.grdp View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 7 chunks +20 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc View 3 chunks +19 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +13 lines, -7 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.cc View 3 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Wez
Created Revert of [Merge to M50] Enable bootstrapping feature by default.
4 years, 8 months ago (2016-04-14 07:23:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887953002/1
4 years, 8 months ago (2016-04-14 07:26:47 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 8 months ago (2016-04-14 07:26:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887953002/1
4 years, 8 months ago (2016-04-14 07:28:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 07:30:27 UTC) #11
Wez
4 years, 8 months ago (2016-04-14 07:37:25 UTC) #12
Message was sent while issue was closed.
PFQ failure contained this:

./src/chrome/browser/chromeos/login/wizard_controller.cc:139:6: error: 'bool
{anonymous}::IsRemoraRequisition()' defined but not used
[-Werror=unused-function]
chromeos-chrome:  bool IsRemoraRequisition() {
chromeos-chrome:       ^
chromeos-chrome: cc1plus: all warnings being treated as errors

Powered by Google App Engine
This is Rietveld 408576698