Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1829453002: Enable bootstrapping feature by default. (Closed)

Created:
4 years, 9 months ago by xdai1
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable bootstrapping feature by default. Currently it was kept disabled behind a command switch --oobe-bootstrapping-slave. BUG=597039 Committed: https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9 Cr-Commit-Position: refs/heads/master@{#383764}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : Fix the builders failure. #

Patch Set 5 : Fix the failed EnterprisePlatformKeysTest.* #

Patch Set 6 : Fix the failed ExistingUserControllerPublicSessionTest.NoAutoLoginWhenUntrusted test. #

Patch Set 7 : Recover the bluetooth adpater's status. #

Patch Set 8 : CL format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -76 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 4 5 6 7 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 7 chunks +27 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc View 3 chunks +5 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 1 chunk +7 lines, -13 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.cc View 1 2 3 4 5 6 3 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
xdai1
Pasha, could you help review this CL please? Thanks!
4 years, 9 months ago (2016-03-22 21:24:16 UTC) #5
xdai1
On 2016/03/22 21:24:16, xdai1 wrote: > Pasha, could you help review this CL please? Thanks! ...
4 years, 9 months ago (2016-03-24 22:41:27 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829453002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829453002/40001
4 years, 9 months ago (2016-03-25 00:07:24 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/111838)
4 years, 9 months ago (2016-03-25 00:21:52 UTC) #10
xdai1
On 2016/03/25 00:21:52, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 9 months ago (2016-03-25 05:59:05 UTC) #12
dzhioev (left Google)
LGTM
4 years, 9 months ago (2016-03-25 22:40:19 UTC) #13
xdai1
emaxx@, could you help review the following file please? Thanks! chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc
4 years, 8 months ago (2016-03-28 17:06:36 UTC) #18
emaxx
On 2016/03/28 17:06:36, xdai1 wrote: > emaxx@, could you help review the following file please? ...
4 years, 8 months ago (2016-03-29 11:30:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829453002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829453002/240001
4 years, 8 months ago (2016-03-29 17:11:14 UTC) #22
commit-bot: I haz the power
Committed patchset #8 (id:240001)
4 years, 8 months ago (2016-03-29 17:54:14 UTC) #24
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:55:53 UTC) #26
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9
Cr-Commit-Position: refs/heads/master@{#383764}

Powered by Google App Engine
This is Rietveld 408576698