Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 188793003: Revert 255357 "Change the user action file format from .txt to ...." (Closed)

Created:
6 years, 9 months ago by dcaiafa
Modified:
6 years, 9 months ago
Reviewers:
yao
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 255357 "Change the user action file format from .txt to ...." Believed to be behind the failures in the Linux builder: http://build.chromium.org/p/chromium/builders/Linux/builds/47996 Errors in the log: .../actions/print_style.py: Has executable bit but not shebang or ELF header .../histograms/print_style.py: Has executable bit but not shebang or ELF header Refers to files in the CL. > Change the user action file format from .txt to .xml. > > In this way, more information can be added (currently added 'description' and 'owner' for each action) > > A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms. > > BUG=340735 > NOTRY=true > > Review URL: https://codereview.chromium.org/149503005 TBR=yiyaoliu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -10514 lines) Patch
M trunk/src/PRESUBMIT.py View 1 chunk +10 lines, -14 lines 0 comments Download
A + trunk/src/tools/metrics/actions/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/tools/metrics/actions/PRESUBMIT.py View 1 chunk +0 lines, -33 lines 0 comments Download
D trunk/src/tools/metrics/actions/actions.xml View 1 chunk +0 lines, -9694 lines 0 comments Download
A + trunk/src/tools/metrics/actions/chromeactions.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/tools/metrics/actions/extract_actions.py View 4 chunks +31 lines, -220 lines 0 comments Download
D trunk/src/tools/metrics/actions/extract_actions_test.py View 1 chunk +0 lines, -199 lines 0 comments Download
D trunk/src/tools/metrics/actions/print_style.py View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/src/tools/metrics/common/diff_util.py View 1 chunk +0 lines, -47 lines 0 comments Download
D trunk/src/tools/metrics/common/pretty_print_xml.py View 1 chunk +0 lines, -193 lines 0 comments Download
A + trunk/src/tools/metrics/histograms/diffutil.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/tools/metrics/histograms/pretty_print.py View 4 chunks +205 lines, -8 lines 0 comments Download
D trunk/src/tools/metrics/histograms/print_style.py View 1 chunk +0 lines, -53 lines 0 comments Download
M trunk/src/tools/metrics/histograms/update_extension_functions.py View 2 chunks +3 lines, -6 lines 0 comments Download
M trunk/src/tools/metrics/histograms/update_policies.py View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dcaiafa
6 years, 9 months ago (2014-03-06 18:55:32 UTC) #1
dcaiafa
6 years, 9 months ago (2014-03-06 18:55:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r255404 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698