Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: trunk/src/tools/metrics/actions/PRESUBMIT.py

Issue 188793003: Revert 255357 "Change the user action file format from .txt to ...." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/metrics/actions/OWNERS ('k') | trunk/src/tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/metrics/actions/PRESUBMIT.py
===================================================================
--- trunk/src/tools/metrics/actions/PRESUBMIT.py (revision 255402)
+++ trunk/src/tools/metrics/actions/PRESUBMIT.py (working copy)
@@ -1,33 +0,0 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""Presubmit script for actions.xml.
-
-See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
-for more details on the presubmit API built into gcl.
-"""
-
-
-def CheckChange(input_api, output_api):
- """Checks that actions.xml is up to date and pretty-printed."""
- for f in input_api.AffectedTextFiles():
- p = f.AbsoluteLocalPath()
- if (input_api.basename(p) == 'actions.xml'
- and input_api.os_path.dirname(p) == input_api.PresubmitLocalPath()):
- cwd = input_api.os_path.dirname(p)
- exit_code = input_api.subprocess.call(
- ['python', 'extract_actions.py', '--presubmit'], cwd=cwd)
- if exit_code != 0:
- return [output_api.PresubmitError(
- 'actions.xml is not up to date or is not formatted correctly; '
- 'run extract_actions.py to fix')]
- return []
-
-
-def CheckChangeOnUpload(input_api, output_api):
- return CheckChange(input_api, output_api)
-
-
-def CheckChangeOnCommit(input_api, output_api):
- return CheckChange(input_api, output_api)
« no previous file with comments | « trunk/src/tools/metrics/actions/OWNERS ('k') | trunk/src/tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698