Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_policy.h

Issue 18878009: Add functions to clean URLs from the activity log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_policy.h
diff --git a/chrome/browser/extensions/activity_log/activity_log_policy.h b/chrome/browser/extensions/activity_log/activity_log_policy.h
index 98bc4ba33bfa181c8131804372312aca74194254..e83eba48bffe7491213e664cb5cc3303ba5bfae6 100644
--- a/chrome/browser/extensions/activity_log/activity_log_policy.h
+++ b/chrome/browser/extensions/activity_log/activity_log_policy.h
@@ -31,6 +31,7 @@ class Extension;
// (1) Summarization (and possibly) compression of data
// (2) Periodical saving of the in-memory state with the database
// (3) Periodical database cleanup
+// (4) Cleaning of URLs
//
// Since every policy implementation might summarize data differently, the
// database implementation is policy-specific and therefore completely
@@ -106,6 +107,11 @@ class ActivityLogPolicy {
<void(scoped_ptr<std::vector<scoped_refptr<Action> > >)>& callback)
const {}
+ // Clean the relevant URL data. The cleaning may be different for different
+ // policies. An empty vector signifies all URLs should be cleaned up.
+ virtual void RemoveURLs(const std::vector<GURL>& gurls) = 0;
mvrable 2013/07/17 16:41:23 You could simplify the code by just providing a si
karenlees 2013/08/08 23:36:37 Done.
+ virtual void RemoveURL(const GURL& gurl) = 0;
+
virtual std::string GetKey(KeyType key_id) const;
protected:

Powered by Google App Engine
This is Rietveld 408576698