Add functions to clean URLs from the activity log

chrome/browser/extensions/activity_log/activity_log_policy.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_LOG_POLICY_H_
 #define CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_LOG_POLICY_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 13 matching lines @@
 namespace extensions {
 
 class Extension;
 
 // Abstract class for summarizing data and storing it into the database.  Any
 // subclass should implement the following functionality:
 //
 // (1) Summarization (and possibly) compression of data
 // (2) Periodical saving of the in-memory state with the database
 // (3) Periodical database cleanup
+// (4) Cleaning of URLs
 //
 // Since every policy implementation might summarize data differently, the
 // database implementation is policy-specific and therefore completely
 // encapsulated in the policy class.  All the member functions can be called
 // on the UI thread, because all DB operations are dispatched via the
 // ActivityDatabase.
 class ActivityLogPolicy {
  public:
   enum PolicyType {
     POLICY_FULLSTREAM,
@@ skipping 55 matching lines @@
   // TODO(felt,dbabic) This is overly specific to the current implementation
   // of the FullStreamUIPolicy.  We should refactor it to use the above
   // more general member function.
   virtual void ReadData(
       const std::string& extension_id,
       const int day,
       const base::Callback
           <void(scoped_ptr<std::vector<scoped_refptr<Action> > >)>& callback)
       const {}
 
+  // Clean the relevant URL data. The cleaning may be different for different
+  // policies. An empty vector signifies all URLs should be cleaned up.
+  virtual void RemoveURLs(const std::vector<GURL>& gurls) = 0;

[mvrable, 2013/07/17 16:41:23]

You could simplify the code by just providing a single method that takes a
vector, and not the RemoveURL method.  It could be fine to keep the multiple
methods on ActivityLog to simplify callers' lives, but reduce the number of
methods that needed to be threaded from ActivityLog -> ActivityLogPolicy ->
ActivityDatabase

[karenlees, 2013/08/08 23:36:37]

Done.

+  virtual void RemoveURL(const GURL& gurl) = 0;
+
   virtual std::string GetKey(KeyType key_id) const;
 
  protected:
   // An ActivityLogPolicy is not directly destroyed.  Instead, call Close()
   // which will cause the object to be deleted when it is safe.
   virtual ~ActivityLogPolicy();
 
   // The Schedule methods dispatch the calls to the database on a
   // separate thread. We dispatch to the UI thread if the DB thread doesn't
   // exist, which should only happen in tests where there is no DB thread.
@@ skipping 24 matching lines @@
 
   base::FilePath profile_base_path_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ActivityLogPolicy);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_LOG_POLICY_H_