Omnibox: Make the Controller Reorder Matches for Inlining

chrome/browser/autocomplete/extension_app_provider.cc

Index: chrome/browser/autocomplete/extension_app_provider.cc
diff --git a/chrome/browser/autocomplete/extension_app_provider.cc b/chrome/browser/autocomplete/extension_app_provider.cc
index 003cdac26bf6ef755fe9782aff1cf380db81cb93..a42af50f85e13394d5a83c1777a752417267314d 100644
--- a/chrome/browser/autocomplete/extension_app_provider.cc
+++ b/chrome/browser/autocomplete/extension_app_provider.cc
@@ -80,6 +80,7 @@ AutocompleteMatch ExtensionAppProvider::CreateAutocompleteMatch(
       app.should_match_against_launch_url ? app.launch_url : input.text();
   match.destination_url = GURL(app.launch_url);
   match.inline_autocomplete_offset = string16::npos;
+  match.allowed_to_be_default_match = true;

[msw, 2013/07/18 06:23:57]

Why is this always true?

[Mark P, 2013/07/21 20:31:05]

Until very recently (when we disabled extensions/apps in the omnibox), they were
allows to be the default match.  For instance, in,  I think, say, M-26, I could
type YouTube or SshInATab and see the YouTube or SshInATab app listed first with
an app icon.  In other words, we've previously allowed apps to be the default
match based on relevance.  This changelist is not trying to change this.

[msw, 2013/07/23 21:55:32]

I suppose this change itself is okay then, should an author verify?
So, is this provider deprecated and should it be deleted?

[Mark P, 2013/07/26 16:48:13]

I'll add an appropriate reviewer and ask these questions when this changelist is
closer to final form.

[msw, 2013/07/26 20:04:49]

I think now would be okay. Your general approach seems reasonable to me and I'm
running out of meaningful comments/Qs; but perhaps Peter has some deeper
concerns or perhaps you'll have a revelation from the more extensive playtesting
and automated tests you're planning. In any case, if this provider should be
deleted, then the question is moot and that change can be handled tangentially.

   match.contents = AutocompleteMatch::SanitizeString(app.name);
   AutocompleteMatch::ClassifyLocationInString(name_match_index,
       input.text().length(), app.name.length(), ACMatchClassification::NONE,