Omnibox: Make the Controller Reorder Matches for Inlining

chrome/browser/autocomplete/extension_app_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/extension_app_provider.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/strings/string16.h"
@@ skipping 62 matching lines @@
     size_t name_match_index,
     size_t url_match_index) {
   // TODO(finnur): Figure out what type to return here, might want to have
   // the extension icon/a generic icon show up in the Omnibox.
   AutocompleteMatch match(this, 0, false,
                           AutocompleteMatchType::EXTENSION_APP);
   match.fill_into_edit =
       app.should_match_against_launch_url ? app.launch_url : input.text();
   match.destination_url = GURL(app.launch_url);
   match.inline_autocomplete_offset = string16::npos;
+  match.allowed_to_be_default_match = true;

[msw, 2013/07/18 06:23:57]

Why is this always true?

[Mark P, 2013/07/21 20:31:05]

Until very recently (when we disabled extensions/apps in the omnibox), they were
allows to be the default match.  For instance, in,  I think, say, M-26, I could
type YouTube or SshInATab and see the YouTube or SshInATab app listed first with
an app icon.  In other words, we've previously allowed apps to be the default
match based on relevance.  This changelist is not trying to change this.

[msw, 2013/07/23 21:55:32]

I suppose this change itself is okay then, should an author verify?
So, is this provider deprecated and should it be deleted?

[Mark P, 2013/07/26 16:48:13]

I'll add an appropriate reviewer and ask these questions when this changelist is
closer to final form.

[msw, 2013/07/26 20:04:49]

I think now would be okay. Your general approach seems reasonable to me and I'm
running out of meaningful comments/Qs; but perhaps Peter has some deeper
concerns or perhaps you'll have a revelation from the more extensive playtesting
and automated tests you're planning. In any case, if this provider should be
deleted, then the question is moot and that change can be handled tangentially.

   match.contents = AutocompleteMatch::SanitizeString(app.name);
   AutocompleteMatch::ClassifyLocationInString(name_match_index,
       input.text().length(), app.name.length(), ACMatchClassification::NONE,
       &match.contents_class);
   if (app.should_match_against_launch_url) {
     match.description = app.launch_url;
     AutocompleteMatch::ClassifyLocationInString(url_match_index,
         input.text().length(), app.launch_url.length(),
         ACMatchClassification::URL, &match.description_class);
   }
@@ skipping 123 matching lines @@
     history::URLRow info;
     url_db->GetRowForURL(url, &info);
     type_count_boost =
         400 * (1.0 - (std::pow(static_cast<double>(2), -info.typed_count())));
   }
   int relevance = 575 + static_cast<int>(type_count_boost) +
                         static_cast<int>(fraction_boost);
   DCHECK_LE(relevance, kMaxRelevance);
   return relevance;
 }