Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1887793002: Correct inline-block baseline calculation for multicol containers. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct inline-block baseline calculation for multicol containers. The last line of something inside a multicol container is in the flow thread coordinate space, so we have to translate the baseline block offset into the visual coordinate space. BUG=335861 Committed: https://crrev.com/fb96232762d2970122aec2e94d52411d65ecb961 Cr-Commit-Position: refs/heads/master@{#387472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/inline-block-baseline.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/inline-block-baseline-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-14 09:08:12 UTC) #2
leviw_travelin_and_unemployed
lgtm Easy breezy!
4 years, 8 months ago (2016-04-14 22:25:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887793002/1
4 years, 8 months ago (2016-04-14 22:26:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 23:32:52 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 23:34:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb96232762d2970122aec2e94d52411d65ecb961
Cr-Commit-Position: refs/heads/master@{#387472}

Powered by Google App Engine
This is Rietveld 408576698