third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h - Issue 1887793002: Correct inline-block baseline calculation for multicol containers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

Issue 1887793002: Correct inline-block baseline calculation for multicol containers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/inline-block-baseline-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

index c898d71336d9103ebd17aa4f0b9a5223038a2a43..a2403ee083d38f0fb21ccff0ae7fb2cbbd6b47e0 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

@@ -185,6 +185,8 @@ public:

LayoutPoint visualPointToFlowThreadPoint(const LayoutPoint& visualPoint) const override;

+ int inlineBlockBaseline(LineDirectionMode) const override;

LayoutMultiColumnSet* columnSetAtBlockOffset(LayoutUnit) const final;

void layoutColumns(SubtreeLayoutScope&);