Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4327)

Unified Diff: chrome/browser/component_updater/origin_trials_component_installer.h

Issue 1887743003: Allow the component updater framework to control Origin Trials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ef-finch
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/origin_trials_component_installer.h
diff --git a/chrome/browser/component_updater/origin_trials_component_installer.h b/chrome/browser/component_updater/origin_trials_component_installer.h
new file mode 100644
index 0000000000000000000000000000000000000000..fd071e52cb1810d869d0cb990e985f3e30444592
--- /dev/null
+++ b/chrome/browser/component_updater/origin_trials_component_installer.h
@@ -0,0 +1,40 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_COMPONENT_UPDATER_ORIGIN_TRIALS_COMPONENT_INSTALLER_H_
+#define CHROME_BROWSER_COMPONENT_UPDATER_ORIGIN_TRIALS_COMPONENT_INSTALLER_H_
+
+#include <stdint.h>
+
+#include <memory>
+#include <string>
+
+#include "components/component_updater/default_component_installer.h"
+
+namespace component_updater {
+
+class OriginTrialsComponentInstallerTraits : public ComponentInstallerTraits {
Sorin Jianu 2016/04/13 21:17:47 use private to declare the appropriate access spec
iclelland 2016/04/14 14:30:08 Yes, done -- thanks. The code was in a pretty roug
+ bool VerifyInstallation(
+ const base::DictionaryValue& manifest,
+ const base::FilePath& install_dir) const override;
+ bool CanAutoUpdate() const override;
+ bool RequiresNetworkEncryption() const override;
+ bool OnCustomInstall(const base::DictionaryValue& manifest,
+ const base::FilePath& install_dir) override;
+ void ComponentReady(const base::Version& version,
+ const base::FilePath& install_dir,
+ std::unique_ptr<base::DictionaryValue> manifest) override;
+ base::FilePath GetBaseDirectory() const override;
+ void GetHash(std::vector<uint8_t>* hash) const override;
+ std::string GetName() const override;
+ std::string GetAp() const override;
+};
+
+// Call once during startup to make the component update service aware of
+// the origin trials update component.
+void RegisterOriginTrialsComponent(ComponentUpdateService* cus,
+ const base::FilePath& user_data_dir);
+
+} // namespace component_updater
Sorin Jianu 2016/04/13 21:17:47 most likely, it needs an empty line after. Also,
iclelland 2016/04/14 14:30:08 Done -- though, oddly, neither lint nor format pic
+#endif // CHROME_BROWSER_COMPONENT_UPDATER_ORIGIN_TRIALS_COMPONENT_INSTALLER_H_

Powered by Google App Engine
This is Rietveld 408576698