Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/component_updater/origin_trials_component_installer.h

Issue 1887743003: Allow the component updater framework to control Origin Trials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ef-finch
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_ORIGIN_TRIALS_COMPONENT_INSTALLER_H_
6 #define CHROME_BROWSER_COMPONENT_UPDATER_ORIGIN_TRIALS_COMPONENT_INSTALLER_H_
7
8 #include <stdint.h>
9
10 #include <memory>
11 #include <string>
12
13 #include "components/component_updater/default_component_installer.h"
14
15 namespace component_updater {
16
17 class OriginTrialsComponentInstallerTraits : public ComponentInstallerTraits {
Sorin Jianu 2016/04/13 21:17:47 use private to declare the appropriate access spec
iclelland 2016/04/14 14:30:08 Yes, done -- thanks. The code was in a pretty roug
18 bool VerifyInstallation(
19 const base::DictionaryValue& manifest,
20 const base::FilePath& install_dir) const override;
21 bool CanAutoUpdate() const override;
22 bool RequiresNetworkEncryption() const override;
23 bool OnCustomInstall(const base::DictionaryValue& manifest,
24 const base::FilePath& install_dir) override;
25 void ComponentReady(const base::Version& version,
26 const base::FilePath& install_dir,
27 std::unique_ptr<base::DictionaryValue> manifest) override;
28 base::FilePath GetBaseDirectory() const override;
29 void GetHash(std::vector<uint8_t>* hash) const override;
30 std::string GetName() const override;
31 std::string GetAp() const override;
32 };
33
34 // Call once during startup to make the component update service aware of
35 // the origin trials update component.
36 void RegisterOriginTrialsComponent(ComponentUpdateService* cus,
37 const base::FilePath& user_data_dir);
38
39 } // namespace component_updater
Sorin Jianu 2016/04/13 21:17:47 most likely, it needs an empty line after. Also,
iclelland 2016/04/14 14:30:08 Done -- though, oddly, neither lint nor format pic
40 #endif // CHROME_BROWSER_COMPONENT_UPDATER_ORIGIN_TRIALS_COMPONENT_INSTALLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698