Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1887733003: Remove redundant DecodingImageGenerator::m_generationId (Closed)

Created:
4 years, 8 months ago by scroggo_chromium
Modified:
4 years, 8 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@sharedBufferInterface6
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant DecodingImageGenerator::m_generationId The field was set based on the SkImage it is used to create. But it got its ID from DecodingImageGenerator's subclass, SkImageGenerator. Just use SkImageGenerator's uniqueID() method directly when needed. No change in behavior. No new tests Committed: https://crrev.com/08b5f549a45e0048000437b71976c754bbf26eab Cr-Commit-Position: refs/heads/master@{#387312}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Remove dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp View 1 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
scroggo_chromium
4 years, 8 months ago (2016-04-13 19:49:24 UTC) #2
f(malita)
lgtm
4 years, 8 months ago (2016-04-14 12:38:35 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1812273003 Patch 560001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-14 12:38:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887733003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887733003/40001
4 years, 8 months ago (2016-04-14 13:22:32 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-14 14:39:28 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 14:40:46 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/08b5f549a45e0048000437b71976c754bbf26eab
Cr-Commit-Position: refs/heads/master@{#387312}

Powered by Google App Engine
This is Rietveld 408576698