third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp - Issue 1887733003: Remove redundant DecodingImageGenerator::m_generationId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

Issue 1887733003: Remove redundant DecodingImageGenerator::m_generationId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sharedBufferInterface6

Patch Set: Remove dependency Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h ('k') | third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

index d857ae67c89a53628bf3340dbbfd11ca35eecedf..920c49ff13041efa68a4941ece6859a19e48f911 100644

--- a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

@@ -38,7 +38,6 @@ DecodingImageGenerator::DecodingImageGenerator(PassRefPtr<ImageFrameGenerator> f

: SkImageGenerator(info)

, m_frameGenerator(frameGenerator)

, m_frameIndex(index)

- , m_generationId(0)

, m_canYUVDecode(false)

{

}

@@ -68,7 +67,7 @@ bool DecodingImageGenerator::onGetPixels(const SkImageInfo& info, void* pixels,

return false;

}

- PlatformInstrumentation::willDecodeLazyPixelRef(m_generationId);

+ PlatformInstrumentation::willDecodeLazyPixelRef(uniqueID());

bool decoded = m_frameGenerator->decodeAndScale(m_frameIndex, getInfo(), pixels, rowBytes);

PlatformInstrumentation::didDecodeLazyPixelRef();

@@ -94,7 +93,7 @@ bool DecodingImageGenerator::onGetYUV8Planes(const SkYUVSizeInfo& sizeInfo, void

TRACE_EVENT1("blink", "DecodingImageGenerator::getYUV8Planes", "frame index", static_cast<int>(m_frameIndex));

- PlatformInstrumentation::willDecodeLazyPixelRef(m_generationId);

+ PlatformInstrumentation::willDecodeLazyPixelRef(uniqueID());

bool decoded = m_frameGenerator->decodeToYUV(m_frameIndex, sizeInfo.fSizes, planes, sizeInfo.fWidthBytes);

PlatformInstrumentation::didDecodeLazyPixelRef();