Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1887713006:
Added tests to check that WebGL extensions are available. (Closed)
|
Created:
4 years, 8 months ago by bajones Modified:
4 years, 8 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded tests to check that WebGL extensions are available.
BUG=603760
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/cbc3d345fe94cc3996cbff5ab1a23733e5ae43ad
Cr-Commit-Position: refs/heads/master@{#388352}
Patch Set 1 #Patch Set 2 : Fixed minor bugs and added more expectations #Patch Set 3 : Hopefully that's the last few expectations #Patch Set 4 : Added test testing test coverage #Patch Set 5 : Added one missing expectation #Patch Set 6 : Sigh... Trying to fix the expectations again. #
Messages
Total messages: 35 (15 generated)
Description was changed from ========== Added tests to check that WebGL extensions are available. BUG=603760 ========== to ========== Added tests to check that WebGL extensions are available. BUG=603760 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
bajones@chromium.org changed reviewers: + kbr@chromium.org, zmo@chromium.org
This isn't ready to land yet because we need to add the expectations for each platform first, but I wanted to get the core code up for feedback while I build that list. Any thoughts?
The CQ bit was checked by bajones@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887713006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887713006/1
Very nice, very elegant.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bajones@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887713006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887713006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Review ping. The expectations should be right now and I'd like to commit this once https://codereview.chromium.org/1883153003/ lands.
On 2016/04/15 23:24:09, bajones wrote: > Review ping. The expectations should be right now and I'd like to commit this > once https://codereview.chromium.org/1883153003/ lands. Can we add a failure mode that an extension that are not expected is detected? This way whenever we expose a new extension, we will not forget updating the list here.
On 2016/04/15 23:28:08, Zhenyao Mo wrote: > On 2016/04/15 23:24:09, bajones wrote: > > Review ping. The expectations should be right now and I'd like to commit this > > once https://codereview.chromium.org/1883153003/ lands. > > Can we add a failure mode that an extension that are not expected is detected? > > This way whenever we expose a new extension, we will not forget updating the > list here. That's a great idea. It can just be something like webgl_negative_extension_test.html and accept the entire set of known extensions. Anything exposed by the context, and not in that known set, should trigger an error. Looks good once Mo's suggestion is addressed.
Added the negative test. Will show up in the test list as
WebglExtension.TestCoverage and failures will produce an error along the lines
of:
"Failure: The following webgl extensions are not being tested and should be
added to GetExtensionList() in content/test/gpu/gpu_tests/webgl_conformance.py:
OES_element_index_uint
OES_standard_derivatives"
PTAL!
Very nice. Thank you for being so thorough. LGTM.
The CQ bit was checked by bajones@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887713006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887713006/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by bajones@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/1887713006/#ps80001 (title: "Added one missing expectation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887713006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887713006/80001
The CQ bit was checked by bajones@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/1887713006/#ps100001 (title: "Sigh... Trying to fix the expectations again.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887713006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887713006/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by bajones@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887713006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887713006/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1903963003/ by kjellander@chromium.org. The reason for reverting is: Seems to break several GPU bots: https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus... https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus... https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus... .
Message was sent while issue was closed.
Description was changed from ========== Added tests to check that WebGL extensions are available. BUG=603760 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Added tests to check that WebGL extensions are available. BUG=603760 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/cbc3d345fe94cc3996cbff5ab1a23733e5ae43ad Cr-Commit-Position: refs/heads/master@{#388352} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/cbc3d345fe94cc3996cbff5ab1a23733e5ae43ad Cr-Commit-Position: refs/heads/master@{#388352} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
