Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: xfa/fwl/core/fwl_threadimp.h

Issue 1887703003: Fold the FWL NoteThread classes up to the Thread classes. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/fwl_noteimp.cpp ('k') | xfa/fwl/core/fwl_threadimp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/fwl_threadimp.h
diff --git a/xfa/fwl/core/fwl_threadimp.h b/xfa/fwl/core/fwl_threadimp.h
index e1787d9d3146a883fe9ec6d9fcffda7d7a0bf856..d10d493899fad8147d9cd1b9ca409cd59ae18d6f 100644
--- a/xfa/fwl/core/fwl_threadimp.h
+++ b/xfa/fwl/core/fwl_threadimp.h
@@ -7,33 +7,27 @@
#ifndef XFA_FWL_CORE_FWL_THREADIMP_H_
#define XFA_FWL_CORE_FWL_THREADIMP_H_
+#include "xfa/fwl/core/fwl_noteimp.h"
#include "xfa/fwl/core/ifwl_thread.h"
-class CFWL_NoteDriver;
class IFWL_NoteDriver;
class IFWL_NoteThread;
class CFWL_ThreadImp {
public:
- virtual ~CFWL_ThreadImp() {}
+ CFWL_ThreadImp(IFWL_Thread* pIface)
+ : m_pNoteDriver(new CFWL_NoteDriver), m_pIface(pIface) {}
+
+ virtual ~CFWL_ThreadImp() { delete m_pNoteDriver; }
Tom Sepez 2016/04/14 21:20:55 nit: virtual dtor should be in .cpp file.
+
IFWL_Thread* GetInterface() const { return m_pIface; }
+ IFWL_NoteDriver* GetNoteDriver() const { return m_pNoteDriver; }
protected:
- CFWL_ThreadImp(IFWL_Thread* pIface) : m_pIface(pIface) {}
+ CFWL_NoteDriver* const m_pNoteDriver;
private:
IFWL_Thread* const m_pIface;
};
-class CFWL_NoteThreadImp : public CFWL_ThreadImp {
- public:
- CFWL_NoteThreadImp(IFWL_NoteThread* pIface);
- virtual ~CFWL_NoteThreadImp();
-
- virtual IFWL_NoteDriver* GetNoteDriver();
-
- protected:
- CFWL_NoteDriver* const m_pNoteDriver;
-};
-
#endif // XFA_FWL_CORE_FWL_THREADIMP_H_
« no previous file with comments | « xfa/fwl/core/fwl_noteimp.cpp ('k') | xfa/fwl/core/fwl_threadimp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698