Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: xfa/fwl/core/fwl_threadimp.h

Issue 1887703003: Fold the FWL NoteThread classes up to the Thread classes. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/core/fwl_noteimp.cpp ('k') | xfa/fwl/core/fwl_threadimp.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef XFA_FWL_CORE_FWL_THREADIMP_H_ 7 #ifndef XFA_FWL_CORE_FWL_THREADIMP_H_
8 #define XFA_FWL_CORE_FWL_THREADIMP_H_ 8 #define XFA_FWL_CORE_FWL_THREADIMP_H_
9 9
10 #include "xfa/fwl/core/fwl_noteimp.h"
10 #include "xfa/fwl/core/ifwl_thread.h" 11 #include "xfa/fwl/core/ifwl_thread.h"
11 12
12 class CFWL_NoteDriver;
13 class IFWL_NoteDriver; 13 class IFWL_NoteDriver;
14 class IFWL_NoteThread; 14 class IFWL_NoteThread;
15 15
16 class CFWL_ThreadImp { 16 class CFWL_ThreadImp {
17 public: 17 public:
18 virtual ~CFWL_ThreadImp() {} 18 CFWL_ThreadImp(IFWL_Thread* pIface)
19 : m_pNoteDriver(new CFWL_NoteDriver), m_pIface(pIface) {}
20
21 virtual ~CFWL_ThreadImp() { delete m_pNoteDriver; }
Tom Sepez 2016/04/14 21:20:55 nit: virtual dtor should be in .cpp file.
22
19 IFWL_Thread* GetInterface() const { return m_pIface; } 23 IFWL_Thread* GetInterface() const { return m_pIface; }
24 IFWL_NoteDriver* GetNoteDriver() const { return m_pNoteDriver; }
20 25
21 protected: 26 protected:
22 CFWL_ThreadImp(IFWL_Thread* pIface) : m_pIface(pIface) {} 27 CFWL_NoteDriver* const m_pNoteDriver;
23 28
24 private: 29 private:
25 IFWL_Thread* const m_pIface; 30 IFWL_Thread* const m_pIface;
26 }; 31 };
27 32
28 class CFWL_NoteThreadImp : public CFWL_ThreadImp {
29 public:
30 CFWL_NoteThreadImp(IFWL_NoteThread* pIface);
31 virtual ~CFWL_NoteThreadImp();
32
33 virtual IFWL_NoteDriver* GetNoteDriver();
34
35 protected:
36 CFWL_NoteDriver* const m_pNoteDriver;
37 };
38
39 #endif // XFA_FWL_CORE_FWL_THREADIMP_H_ 33 #endif // XFA_FWL_CORE_FWL_THREADIMP_H_
OLDNEW
« no previous file with comments | « xfa/fwl/core/fwl_noteimp.cpp ('k') | xfa/fwl/core/fwl_threadimp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698