Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1887593002: Fall back to env before using static defaults

Created:
4 years, 8 months ago by jbergstroem
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Fall back to env before using static defaults The Makefile generator now falls back to CC/CXX/LINK/AR instead of using static defaults. This makes it easier to use Gyp on platforms like FreeBSD which only defaults to a clang toolchain. BUG= Downstream PR: https://github.com/nodejs/node/pull/6173 Downstream Issue: https://github.com/nodejs/node/issues/6152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pylib/gyp/generator/make.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
jbergstroem
Description was changed from ========== Fall back to env before using static defaults The Makefile ...
4 years, 8 months ago (2016-04-13 13:15:01 UTC) #1
jbergstroem
johan@bergstroem.nu changed reviewers: + thakis@chromium.org
4 years, 8 months ago (2016-04-13 13:15:01 UTC) #2
jbergstroem
4 years, 8 months ago (2016-04-20 01:20:19 UTC) #3 
Description was changed from

==========
Fall back to env before using static defaults

The Makefile generator now falls back to CC/CXX/LINK/AR
instead of using static defaults. This makes it easier to
use Gyp on platforms like FreeBSD which only defaults to a
clang toolchain.

BUG=
==========

to

==========
Fall back to env before using static defaults

The Makefile generator now falls back to CC/CXX/LINK/AR
instead of using static defaults. This makes it easier to
use Gyp on platforms like FreeBSD which only defaults to a
clang toolchain.

BUG=

Downstream PR: https://github.com/nodejs/node/pull/6173
Downstream Issue: https://github.com/nodejs/node/issues/6152
==========

Powered by Google App Engine
This is Rietveld 408576698