Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1887403002: Create a WebUIController for chrome://suggestions (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a WebUIController for chrome://suggestions This ensures that the URLDataSource is properly registered at startup. BUG=597653 Committed: https://crrev.com/0c8e07604abddf7f02daee2ad48314e12f2688b2 Cr-Commit-Position: refs/heads/master@{#388197}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : move SuggestionsSource #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -310 lines) Patch
M chrome/browser/android/ntp/most_visited_sites.cc View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/search/instant_service.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/search/suggestions/suggestions_source.h View 1 2 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/search/suggestions/suggestions_source.cc View 1 2 1 chunk +0 lines, -218 lines 0 comments Download
A chrome/browser/search/suggestions/suggestions_ui.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A + chrome/browser/search/suggestions/suggestions_ui.cc View 1 2 4 chunks +67 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Marc Treib
PTAL!
4 years, 8 months ago (2016-04-15 10:51:56 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/1887403002/diff/20001/chrome/browser/search/suggestions/suggestions_ui.cc File chrome/browser/search/suggestions/suggestions_ui.cc (right): https://codereview.chromium.org/1887403002/diff/20001/chrome/browser/search/suggestions/suggestions_ui.cc#newcode13 chrome/browser/search/suggestions/suggestions_ui.cc:13: SuggestionsUI::SuggestionsUI(content::WebUI* web_ui) You could move the SuggestionsSource into an ...
4 years, 8 months ago (2016-04-18 08:07:22 UTC) #3
Marc Treib
https://codereview.chromium.org/1887403002/diff/20001/chrome/browser/search/suggestions/suggestions_ui.cc File chrome/browser/search/suggestions/suggestions_ui.cc (right): https://codereview.chromium.org/1887403002/diff/20001/chrome/browser/search/suggestions/suggestions_ui.cc#newcode13 chrome/browser/search/suggestions/suggestions_ui.cc:13: SuggestionsUI::SuggestionsUI(content::WebUI* web_ui) On 2016/04/18 08:07:22, Bernhard Bauer wrote: > ...
4 years, 8 months ago (2016-04-19 12:06:48 UTC) #4
Bernhard Bauer
LGTM, thanks!
4 years, 8 months ago (2016-04-19 12:12:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887403002/40001
4 years, 8 months ago (2016-04-19 12:13:12 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-19 13:03:55 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 13:05:16 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/0c8e07604abddf7f02daee2ad48314e12f2688b2
Cr-Commit-Position: refs/heads/master@{#388197}

Powered by Google App Engine
This is Rietveld 408576698