chrome/browser/search/suggestions/suggestions_ui.cc - Issue 1887403002: Create a WebUIController for chrome://suggestions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/search/suggestions/suggestions_ui.cc

Issue 1887403002: Create a WebUIController for chrome://suggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/search/suggestions/suggestions_ui.h"

	6

	7 #include "chrome/browser/profiles/profile.h"

	8 #include "chrome/browser/search/suggestions/suggestions_source.h"

	9 #include "content/public/browser/url_data_source.h"

	10

	11 namespace suggestions {

	12

	13 SuggestionsUI::SuggestionsUI(content::WebUI* web_ui)
	Bernhard Bauer 2016/04/18 08:07:22 You could move the SuggestionsSource into an anony You could move the SuggestionsSource into an anonymous namespace here now, as it's not used anywhere else. That's a fairly common pattern for Web UI code. Marc Treib 2016/04/19 12:06:47 Done. Show quoted text On 2016/04/18 08:07:22, Bernhard Bauer wrote: > You could move the SuggestionsSource into an anonymous namespace here now, as > it's not used anywhere else. That's a fairly common pattern for Web UI code. Done.
	14 : content::WebUIController(web_ui) {

	15 Profile* profile = Profile::FromWebUI(web_ui);

	16 content::URLDataSource::Add(profile, new SuggestionsSource(profile));

	17 }

	18

	19 SuggestionsUI::~SuggestionsUI() {}

	20

	21 } // namespace suggestions

OLD	NEW