Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1887343002:
[turbofan] Remove the leftover LoadBuffer hacks. (Closed)
|
Created:
4 years, 8 months ago by Benedikt Meurer Modified:
4 years, 8 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Remove the leftover LoadBuffer hacks.
R=jarin@chromium.org
Committed: https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22
Cr-Commit-Position: refs/heads/master@{#35509}
Committed: https://crrev.com/ef4ad3eb0f71ff695f8ddbc698faa109ba7bf2a4
Cr-Commit-Position: refs/heads/master@{#35550}
Patch Set 1 #Patch Set 2 : Fix #
Messages
Total messages: 21 (10 generated)
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887343002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
mstarzinger@chromium.org changed reviewers: + mstarzinger@chromium.org
TLGM (that looks good man), for when an LGTM just doesn't cut it. :)
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887343002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Remove the leftover LoadBuffer hacks. R=jarin@chromium.org ========== to ========== [turbofan] Remove the leftover LoadBuffer hacks. R=jarin@chromium.org Committed: https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22 Cr-Commit-Position: refs/heads/master@{#35509} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22 Cr-Commit-Position: refs/heads/master@{#35509}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1893893002/ by bmeurer@chromium.org. The reason for reverting is: Using types in ChangeLowering is generally unsafe..
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Remove the leftover LoadBuffer hacks. R=jarin@chromium.org Committed: https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22 Cr-Commit-Position: refs/heads/master@{#35509} ========== to ========== [turbofan] Remove the leftover LoadBuffer hacks. R=jarin@chromium.org Committed: https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22 Cr-Commit-Position: refs/heads/master@{#35509} ==========
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mstarzinger@chromium.org Link to the patchset: https://codereview.chromium.org/1887343002/#ps20001 (title: "Fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887343002/20001
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Remove the leftover LoadBuffer hacks. R=jarin@chromium.org Committed: https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22 Cr-Commit-Position: refs/heads/master@{#35509} ========== to ========== [turbofan] Remove the leftover LoadBuffer hacks. R=jarin@chromium.org Committed: https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22 Cr-Commit-Position: refs/heads/master@{#35509} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Remove the leftover LoadBuffer hacks. R=jarin@chromium.org Committed: https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22 Cr-Commit-Position: refs/heads/master@{#35509} ========== to ========== [turbofan] Remove the leftover LoadBuffer hacks. R=jarin@chromium.org Committed: https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22 Cr-Commit-Position: refs/heads/master@{#35509} Committed: https://crrev.com/ef4ad3eb0f71ff695f8ddbc698faa109ba7bf2a4 Cr-Commit-Position: refs/heads/master@{#35550} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ef4ad3eb0f71ff695f8ddbc698faa109ba7bf2a4 Cr-Commit-Position: refs/heads/master@{#35550} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
