Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: src/compiler/simplified-lowering.h

Issue 1887343002: [turbofan] Remove the leftover LoadBuffer hacks. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/pipeline.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_SIMPLIFIED_LOWERING_H_ 5 #ifndef V8_COMPILER_SIMPLIFIED_LOWERING_H_
6 #define V8_COMPILER_SIMPLIFIED_LOWERING_H_ 6 #define V8_COMPILER_SIMPLIFIED_LOWERING_H_
7 7
8 #include "src/compiler/js-graph.h" 8 #include "src/compiler/js-graph.h"
9 #include "src/compiler/machine-operator.h" 9 #include "src/compiler/machine-operator.h"
10 #include "src/compiler/node.h" 10 #include "src/compiler/node.h"
(...skipping 20 matching lines...) Expand all
31 31
32 void LowerAllNodes(); 32 void LowerAllNodes();
33 33
34 // TODO(turbofan): The representation can be removed once the result of the 34 // TODO(turbofan): The representation can be removed once the result of the
35 // representation analysis is stored in the node bounds. 35 // representation analysis is stored in the node bounds.
36 void DoLoadBuffer(Node* node, MachineRepresentation rep, 36 void DoLoadBuffer(Node* node, MachineRepresentation rep,
37 RepresentationChanger* changer); 37 RepresentationChanger* changer);
38 void DoStoreBuffer(Node* node); 38 void DoStoreBuffer(Node* node);
39 void DoShift(Node* node, Operator const* op, Type* rhs_type); 39 void DoShift(Node* node, Operator const* op, Type* rhs_type);
40 40
41 // TODO(bmeurer): This is a gigantic hack to support the gigantic LoadBuffer
42 // typing hack to support the gigantic "asm.js should be fast without proper
43 // verifier"-hack, ... Kill this! Soon! Really soon! I'm serious!
44 bool abort_compilation_ = false;
45
46 private: 41 private:
47 JSGraph* const jsgraph_; 42 JSGraph* const jsgraph_;
48 Zone* const zone_; 43 Zone* const zone_;
49 TypeCache const& type_cache_; 44 TypeCache const& type_cache_;
50 45
51 // TODO(danno): SimplifiedLowering shouldn't know anything about the source 46 // TODO(danno): SimplifiedLowering shouldn't know anything about the source
52 // positions table, but must for now since there currently is no other way to 47 // positions table, but must for now since there currently is no other way to
53 // pass down source position information to nodes created during 48 // pass down source position information to nodes created during
54 // lowering. Once this phase becomes a vanilla reducer, it should get source 49 // lowering. Once this phase becomes a vanilla reducer, it should get source
55 // position information via the SourcePositionWrapper like all other reducers. 50 // position information via the SourcePositionWrapper like all other reducers.
(...skipping 16 matching lines...) Expand all
72 Graph* graph() { return jsgraph()->graph(); } 67 Graph* graph() { return jsgraph()->graph(); }
73 CommonOperatorBuilder* common() { return jsgraph()->common(); } 68 CommonOperatorBuilder* common() { return jsgraph()->common(); }
74 MachineOperatorBuilder* machine() { return jsgraph()->machine(); } 69 MachineOperatorBuilder* machine() { return jsgraph()->machine(); }
75 }; 70 };
76 71
77 } // namespace compiler 72 } // namespace compiler
78 } // namespace internal 73 } // namespace internal
79 } // namespace v8 74 } // namespace v8
80 75
81 #endif // V8_COMPILER_SIMPLIFIED_LOWERING_H_ 76 #endif // V8_COMPILER_SIMPLIFIED_LOWERING_H_
OLDNEW
« no previous file with comments | « src/compiler/pipeline.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698