Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1887303004: Revert of Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from ... (Closed)

Created:
4 years, 8 months ago by EhsanK
Modified:
4 years, 8 months ago
Reviewers:
kenrb, Charlie Reis, lazyboy
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from Delegate (patchset #5 id:80001 of https://codereview.chromium.org/1879453002/ ) Reason for revert: This is needed to revert https://codereview.chromium.org/1652483002/. The original CL caused many regressions. Original issue's description: > Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from Delegate > > During the destruction of WebContentsImpl, the RWHs are first detached and then destroyed. If some RWHV > has an active input field, then it will never get a chance to notify the WebContentsImpl about > losing being destroyed and the WebContentsImpl will track the wrong text input state. This will > cause DCHECK in WebContentsImpl::GetTextInputState being triggered, specifically, for an outer WebContents > which might outlive the WebContents being destroyed. > > BUG=602144, 601570 > > Committed: https://crrev.com/5292d041d34d49e8c3e851a0e21504a983e5be57 > Cr-Commit-Position: refs/heads/master@{#387311} TBR=creis@chromium.org,kenrb@chromium.org,lazyboy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=602144, 601570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -64 lines) Patch
M chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc View 2 chunks +4 lines, -38 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.js View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
EhsanK
Created Revert of Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from Delegate
4 years, 8 months ago (2016-04-15 19:18:02 UTC) #1
Charlie Reis
Should this one be closed in favor of https://codereview.chromium.org/1889313002/? (I see it's doing a CQ ...
4 years, 8 months ago (2016-04-15 20:52:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887303004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887303004/1
4 years, 8 months ago (2016-04-15 21:01:32 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 21:31:01 UTC) #8
EhsanK
4 years, 8 months ago (2016-04-22 19:13:33 UTC) #9
On 2016/04/15 21:31:01, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Closing in favor of https://codereview.chromium.org/1889313002/ which has
already landed.

Powered by Google App Engine
This is Rietveld 408576698