Chromium Code Reviews
DescriptionRevert of Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from Delegate (patchset #5 id:80001 of https://codereview.chromium.org/1879453002/ )
Reason for revert:
This is needed to revert
https://codereview.chromium.org/1652483002/. The original CL caused many regressions.
Original issue's description:
> Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from Delegate
>
> During the destruction of WebContentsImpl, the RWHs are first detached and then destroyed. If some RWHV
> has an active input field, then it will never get a chance to notify the WebContentsImpl about
> losing being destroyed and the WebContentsImpl will track the wrong text input state. This will
> cause DCHECK in WebContentsImpl::GetTextInputState being triggered, specifically, for an outer WebContents
> which might outlive the WebContents being destroyed.
>
> BUG=602144, 601570
>
> Committed: https://crrev.com/5292d041d34d49e8c3e851a0e21504a983e5be57
> Cr-Commit-Position: refs/heads/master@{#387311}
TBR=creis@chromium.org,kenrb@chromium.org,lazyboy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=602144, 601570
Patch Set 1 #
Messages
Total messages: 9 (4 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||