content/browser/browser_plugin/browser_plugin_guest.cc - Issue 1887303004: Revert of Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 1887303004: Revert of Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from ... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.js ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index 2b8e20dd248232d50bffe0bdf94a5d5457d210d7..fa72b21111d79b812cf51ec14641554bb08f35bb 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -36,7 +36,6 @@

#include "content/common/host_shared_bitmap_manager.h"

#include "content/common/input_messages.h"

#include "content/common/site_isolation_policy.h"

-#include "content/common/text_input_state.h"

#include "content/common/view_messages.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/browser_plugin_guest_manager.h"

@@ -776,14 +775,6 @@

void BrowserPluginGuest::OnDetach(int browser_plugin_instance_id) {

if (!attached())

return;

- // The BrowserPluginGuest loses the link to |owner_web_contents_|. Therefore,

- // the RenderWidgetHostViewGuest will not get a chance to update its text

- // input state which is tracked by |owner_web_contents_|.

- // TODO(ekaramad): We should perform detaching through WebContentsImpl (

- // inner WebContents detaching from outer WebContents). After this is fixed,

- // we can remove this call to OnTextInputStateChanged (crbug.com/602640).

- OnTextInputStateChanged(TextInputState());

// This tells BrowserPluginGuest to queue up all IPCs to BrowserPlugin until

// it's attached again.