Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 1887073002: skia bugs found with first test pdf (Closed)

Created:
4 years, 8 months ago by caryclark
Modified:
4 years, 8 months ago
Reviewers:
dsinclair, rmistry
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

skia bugs found with first test pdf The first PDF attempted by the Skia infra team uncovered three bugs. This gets past those bugs crashing; more work to do to get the correct output. R=rmistry@google.com,dsinclair@chromium.org BUG=skia:5183 Committed: https://pdfium.googlesource.com/pdfium/+/725a49f7a64a3537c081cd23cf7d5d6578efdfa1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M core/fxge/skia/fx_skia_device.cpp View 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caryclark
4 years, 8 months ago (2016-04-14 15:51:01 UTC) #1
dsinclair
lgtm Is the PDF public? Can we make a test case out of it?
4 years, 8 months ago (2016-04-14 15:53:20 UTC) #2
caryclark
On 2016/04/14 15:53:20, dsinclair wrote: > lgtm > > Is the PDF public? Can we ...
4 years, 8 months ago (2016-04-14 15:56:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887073002/1
4 years, 8 months ago (2016-04-14 15:56:53 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 16:09:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/725a49f7a64a3537c081cd23cf7d5d6578ef...

Powered by Google App Engine
This is Rietveld 408576698