skia bugs found with first test pdf

core/fxge/skia/fx_skia_device.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/fxge/include/fx_ge.h"
 
 #if defined(_SKIA_SUPPORT_)
 #include "core/fxcodec/include/fx_codec.h"
 
 #include "core/fpdfapi/fpdf_page/cpdf_shadingpattern.h"
@@ skipping 705 matching lines @@
     const CFX_GraphStateData* pGraphState,  // graphic state, for pen attributes
     uint32_t fill_color,                    // fill color
     uint32_t stroke_color,                  // stroke color
     int fill_mode,  // fill mode, WINDING or ALTERNATE. 0 for not filled
     int alpha_flag,
     void* pIccTransform,
     int blend_type) {
   SkIRect rect;
   rect.set(0, 0, GetDeviceCaps(FXDC_PIXEL_WIDTH),
            GetDeviceCaps(FXDC_PIXEL_HEIGHT));
-  SkMatrix skMatrix = ToSkMatrix(*pObject2Device);
+  SkMatrix skMatrix;
+  if (pObject2Device)
+    skMatrix = ToSkMatrix(*pObject2Device);
+  else
+    skMatrix.setIdentity();
   SkPaint skPaint;
   skPaint.setAntiAlias(true);
   int stroke_alpha = FXGETFLAG_COLORTYPE(alpha_flag)
                          ? FXGETFLAG_ALPHA_STROKE(alpha_flag)
                          : FXARGB_A(stroke_color);
   if (pGraphState && stroke_alpha)
     PaintStroke(&skPaint, pGraphState, skMatrix);
   SkPath skPath = BuildPath(pPathData);
   m_pCanvas->save();
   m_pCanvas->concat(skMatrix);
@@ skipping 189 matching lines @@
   pRect->right = canvasSize.width();
   pRect->bottom = canvasSize.height();
   return TRUE;
 }
 
 FX_BOOL CFX_SkiaDeviceDriver::GetDIBits(CFX_DIBitmap* pBitmap,
                                         int left,
                                         int top,
                                         void* pIccTransform,
                                         FX_BOOL bDEdge) {
-  if (!m_pBitmap->GetBuffer())
+  if (!m_pBitmap || !m_pBitmap->GetBuffer())
     return TRUE;
   if (bDEdge) {
     if (m_bRgbByteOrder) {
       RgbByteOrderTransferBitmap(pBitmap, 0, 0, pBitmap->GetWidth(),
                                  pBitmap->GetHeight(), m_pBitmap, left, top);
     } else {
       return pBitmap->TransferBitmap(0, 0, pBitmap->GetWidth(),
                                      pBitmap->GetHeight(), m_pBitmap, left, top,
                                      pIccTransform);
     }
@@ skipping 28 matching lines @@
 }
 
 FX_BOOL CFX_SkiaDeviceDriver::SetDIBits(const CFX_DIBSource* pBitmap,
                                         uint32_t argb,
                                         const FX_RECT* pSrcRect,
                                         int left,
                                         int top,
                                         int blend_type,
                                         int alpha_flag,
                                         void* pIccTransform) {
-  if (!m_pBitmap->GetBuffer())
+  if (!m_pBitmap || !m_pBitmap->GetBuffer())
     return TRUE;
   if (pBitmap->IsAlphaMask()) {
     return m_pBitmap->CompositeMask(
         left, top, pSrcRect->Width(), pSrcRect->Height(), pBitmap, argb,
         pSrcRect->left, pSrcRect->top, blend_type, nullptr, m_bRgbByteOrder,
         alpha_flag, pIccTransform);
   }
   return m_pBitmap->CompositeBitmap(
       left, top, pSrcRect->Width(), pSrcRect->Height(), pBitmap, pSrcRect->left,
       pSrcRect->top, blend_type, nullptr, m_bRgbByteOrder, pIccTransform);
@@ skipping 62 matching lines @@
         const uint8_t* srcRow =
             static_cast<const uint8_t*>(buffer) + y * rowBytes;
         uint8_t* dstRow = dst8Pixels + y * width;
         for (int x = 0; x < width; ++x)
           dstRow[x] = srcRow[x >> 3] & (1 << (~x & 0x07)) ? one : zero;
       }
       buffer = dst8Storage.get();
       rowBytes = width;
       colorType = SkColorType::kGray_8_SkColorType;
     } break;
+    case 8:
+      colorType = SkColorType::kGray_8_SkColorType;
+      break;
     case 24: {
       dst32Storage.reset(FX_Alloc2D(uint32_t, width, height));
       uint32_t* dst32Pixels = dst32Storage.get();
       for (int y = 0; y < height; ++y) {
         const uint8_t* srcRow =
             static_cast<const uint8_t*>(buffer) + y * rowBytes;
         uint32_t* dstRow = dst32Pixels + y * width;
         for (int x = 0; x < width; ++x)
           dstRow[x] = SkPackARGB32(0xFF, srcRow[x * 3 + 2], srcRow[x * 3 + 1],
                                    srcRow[x * 3 + 0]);
@@ skipping 99 matching lines @@
   SetDeviceDriver(pDriver);
   return TRUE;
 }
 
 CFX_SkiaDevice::~CFX_SkiaDevice() {
   if (m_bOwnedBitmap && GetBitmap())
     delete GetBitmap();
 }
 
 #endif