Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1886973005: cc: Clear the |layer_id_to_scroll_offset_map_| during ScrollTree deserialization . (Closed)

Created:
4 years, 8 months ago by Khushal
Modified:
4 years, 8 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Clear the |layer_id_to_scroll_offset_map_| during ScrollTree deserialization. This should be cleared when a new property tree is created in the LayerTreeHost during deserialization but the ScrollTree copy constructor retains this map. BUG=603271 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d0b61b1bed0afc451d7bb724ed9f27ec5e7205bc Cr-Commit-Position: refs/heads/master@{#387743}

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 2

Patch Set 3 : Add back previous test expectation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M cc/trees/property_tree.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Khushal
4 years, 8 months ago (2016-04-15 19:25:16 UTC) #5
vmpstr
test?
4 years, 8 months ago (2016-04-15 20:34:47 UTC) #6
Khushal
On 2016/04/15 20:34:47, vmpstr wrote: > test? Done.
4 years, 8 months ago (2016-04-15 21:35:40 UTC) #7
vmpstr
lgtm https://codereview.chromium.org/1886973005/diff/20001/cc/trees/property_tree_unittest.cc File cc/trees/property_tree_unittest.cc (right): https://codereview.chromium.org/1886973005/diff/20001/cc/trees/property_tree_unittest.cc#newcode282 cc/trees/property_tree_unittest.cc:282: nit: can you add an EXPECT_EQ(original, result) here ...
4 years, 8 months ago (2016-04-15 21:39:16 UTC) #8
Khushal
Thanks! https://codereview.chromium.org/1886973005/diff/20001/cc/trees/property_tree_unittest.cc File cc/trees/property_tree_unittest.cc (right): https://codereview.chromium.org/1886973005/diff/20001/cc/trees/property_tree_unittest.cc#newcode282 cc/trees/property_tree_unittest.cc:282: On 2016/04/15 21:39:15, vmpstr wrote: > nit: can ...
4 years, 8 months ago (2016-04-15 21:52:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886973005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886973005/40001
4 years, 8 months ago (2016-04-15 21:53:05 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-15 23:20:36 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 23:21:47 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d0b61b1bed0afc451d7bb724ed9f27ec5e7205bc
Cr-Commit-Position: refs/heads/master@{#387743}

Powered by Google App Engine
This is Rietveld 408576698