Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: cc/trees/property_tree_unittest.cc

Issue 1886973005: cc: Clear the |layer_id_to_scroll_offset_map_| during ScrollTree deserialization . (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/property_tree.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/property_tree.h" 5 #include "cc/trees/property_tree.h"
6 6
7 #include "cc/input/main_thread_scrolling_reason.h" 7 #include "cc/input/main_thread_scrolling_reason.h"
8 #include "cc/proto/property_tree.pb.h" 8 #include "cc/proto/property_tree.pb.h"
9 #include "cc/test/geometry_test_utils.h" 9 #include "cc/test/geometry_test_utils.h"
10 #include "cc/trees/draw_property_utils.h" 10 #include "cc/trees/draw_property_utils.h"
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 original.Insert(second, 0); 272 original.Insert(second, 0);
273 original.Insert(third, 1); 273 original.Insert(third, 1);
274 274
275 original.set_currently_scrolling_node(1); 275 original.set_currently_scrolling_node(1);
276 original.SetScrollOffset(1, gfx::ScrollOffset(1, 2)); 276 original.SetScrollOffset(1, gfx::ScrollOffset(1, 2));
277 277
278 proto::PropertyTree proto; 278 proto::PropertyTree proto;
279 original.ToProtobuf(&proto); 279 original.ToProtobuf(&proto);
280 ScrollTree result; 280 ScrollTree result;
281 result.FromProtobuf(proto); 281 result.FromProtobuf(proto);
282 282
vmpstr 2016/04/15 21:39:15 nit: can you add an EXPECT_EQ(original, result) he
Khushal 2016/04/15 21:52:39 Done.
283 original.clear();
284 original.set_currently_scrolling_node(0);
285 original.SetScrollOffset(2, gfx::ScrollOffset(1, 2));
286
287 proto::PropertyTree proto2;
288 original.ToProtobuf(&proto2);
289 result = ScrollTree();
290 result.FromProtobuf(proto2);
291
283 EXPECT_EQ(original, result); 292 EXPECT_EQ(original, result);
284 } 293 }
285 294
286 TEST(PropertyTreeSerializationTest, PropertyTrees) { 295 TEST(PropertyTreeSerializationTest, PropertyTrees) {
287 PropertyTrees original; 296 PropertyTrees original;
288 original.transform_tree.Insert(TransformNode(), 0); 297 original.transform_tree.Insert(TransformNode(), 0);
289 original.transform_tree.Insert(TransformNode(), 1); 298 original.transform_tree.Insert(TransformNode(), 1);
290 original.clip_tree.Insert(ClipNode(), 0); 299 original.clip_tree.Insert(ClipNode(), 0);
291 original.clip_tree.Insert(ClipNode(), 1); 300 original.clip_tree.Insert(ClipNode(), 1);
292 original.effect_tree.Insert(EffectNode(), 0); 301 original.effect_tree.Insert(EffectNode(), 0);
(...skipping 792 matching lines...) Expand 10 before | Expand all | Expand 10 after
1085 1094
1086 DIRECT_AND_SERIALIZED_PROPERTY_TREE_TEST_F( 1095 DIRECT_AND_SERIALIZED_PROPERTY_TREE_TEST_F(
1087 PropertyTreeTestSingularTransformSnapTest); 1096 PropertyTreeTestSingularTransformSnapTest);
1088 1097
1089 #undef DIRECT_AND_SERIALIZED_PROPERTY_TREE_TEST_F 1098 #undef DIRECT_AND_SERIALIZED_PROPERTY_TREE_TEST_F
1090 #undef SERIALIZED_PROPERTY_TREE_TEST_F 1099 #undef SERIALIZED_PROPERTY_TREE_TEST_F
1091 #undef DIRECT_PROPERTY_TREE_TEST_F 1100 #undef DIRECT_PROPERTY_TREE_TEST_F
1092 1101
1093 } // namespace 1102 } // namespace
1094 } // namespace cc 1103 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/property_tree.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698