Issue 188693008: Implement the clip as 4 or fewer GrEffects when possible.

Issue 188693008: Implement the clip as 4 or fewer GrEffects when possible. (Closed)

Created:
6 years, 9 months ago by bsalomon

Modified:
6 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Implement the clip as 4 or fewer GrEffects when possible. BUG=skia:2181 Committed: http://code.google.com/p/skia/source/detail?r=13710

Patch Set 4 : minor comment update #

Patch Set 5 : upload again, rietveld diff failed. #

Total comments: 2

Patch Set 6 : fix comment spelling #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -55 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	1 2 3 4 5	2 chunks	+118 lines, -50 lines	0 comments	Download
M	src/gpu/effects/GrConvexPolyEffect.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/effects/GrRRectEffect.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bsalomon

tabl_worldjournal.skp 11ms->5ms on Z620, 113ms->21ms on N5.

6 years, 9 months ago (2014-03-06 22:20:22 UTC) #1

robertphillips

Can you re-upload? I'm seeing chunk mismatch errors.

6 years, 9 months ago (2014-03-06 23:15:43 UTC) #2

robertphillips

lgtm + 1 typo https://codereview.chromium.org/188693008/diff/80001/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/188693008/diff/80001/src/gpu/GrClipMaskManager.cpp#newcode258 src/gpu/GrClipMaskManager.cpp:258: add 't' to elemen?

6 years, 9 months ago (2014-03-07 18:32:20 UTC) #3

bsalomon

https://codereview.chromium.org/188693008/diff/80001/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/188693008/diff/80001/src/gpu/GrClipMaskManager.cpp#newcode258 src/gpu/GrClipMaskManager.cpp:258: On 2014/03/07 18:32:20, robertphillips wrote: > add 't' to ...

6 years, 9 months ago (2014-03-07 18:45:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/188693008/100001

6 years, 9 months ago (2014-03-07 18:45:51 UTC) #6

Message was sent while issue was closed.

Change committed as 13710

Expand Messages | Collapse Messages